From: Roel Kluin <12o3l@tiscali.nl>
To: "Uwe Kleine-König" <ukleinek@informatik.uni-freiburg.de>,
"Roel Kluin" <12o3l@tiscali.nl>,
linux-serial@vger.kernel.org
Subject: Re: questions regarding function autoconfig(); drivers/serial/8250.c
Date: Mon, 26 Nov 2007 18:40:38 +0100 [thread overview]
Message-ID: <474B0516.9020103@tiscali.nl> (raw)
In-Reply-To: <20071126124646.GA11351@informatik.uni-freiburg.de>
Uwe Kleine-König wrote:
> Roel Kluin wrote:
>> In drivers/serial/8250.c:995 it reads:
>>
>> if (!up->port.iobase && !up->port.mapbase && !up->port.membase)
>> return;
>>
>> As you can see the test !up->port.mapbase is duplicated, which makes no sense.
>> maybe a different test was intended here?
> Looking twice exposes that the second mapbase is actually a membase. So
> it looks right to me.
>
> Best regards
> Uwe
Thanks for the regards, clearly I need some glasses to improve mine.
Roel
-
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2007-11-26 17:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-23 22:42 questions regarding function autoconfig(); drivers/serial/8250.c Roel Kluin
2007-11-26 12:46 ` Uwe Kleine-König
2007-11-26 17:40 ` Roel Kluin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=474B0516.9020103@tiscali.nl \
--to=12o3l@tiscali.nl \
--cc=linux-serial@vger.kernel.org \
--cc=ukleinek@informatik.uni-freiburg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).