questions regarding function autoconfig(); drivers/serial/8250.c

questions regarding function autoconfig(); drivers/serial/8250.c

[Roel Kluin]

In drivers/serial/8250.c:995 it reads:

if (!up->port.iobase && !up->port.mapbase && !up->port.membase)
	return;

As you can see the test !up->port.mapbase is duplicated, which makes no sense.
maybe a different test was intended here?
also since membase is a pointer shouldn't the '&&' be replaced with '||'?

thanks,

Roel

Re: questions regarding function autoconfig(); drivers/serial/8250.c

[Uwe Kleine-König]

Roel Kluin wrote:
> In drivers/serial/8250.c:995 it reads:
> 
> if (!up->port.iobase && !up->port.mapbase && !up->port.membase)
> 	return;
> 
> As you can see the test !up->port.mapbase is duplicated, which makes no sense.
> maybe a different test was intended here?
Looking twice exposes that the second mapbase is actually a membase.  So
it looks right to me.

Best regards
Uwe

-- 
Uwe Kleine-König

http://www.google.com/search?q=30+hours+and+4+days+in+seconds
-
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: questions regarding function autoconfig(); drivers/serial/8250.c

[Roel Kluin]

Uwe Kleine-König wrote:
> Roel Kluin wrote:
>> In drivers/serial/8250.c:995 it reads:
>>
>> if (!up->port.iobase && !up->port.mapbase && !up->port.membase)
>> 	return;
>>
>> As you can see the test !up->port.mapbase is duplicated, which makes no sense.
>> maybe a different test was intended here?
> Looking twice exposes that the second mapbase is actually a membase.  So
> it looks right to me.
> 
> Best regards
> Uwe

Thanks for the regards, clearly I need some glasses to improve mine.

Roel
-
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html