From: David Daney <ddaney@caviumnetworks.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-serial@vger.kernel.org, akpm@linux-foundation.org,
linux-mips@linux-mips.org,
Tomaso Paoletti <tpaoletti@caviumnetworks.com>
Subject: Re: [PATCH 1/4] 8250: Don't clobber spinlocks.
Date: Tue, 02 Dec 2008 09:01:13 -0800 [thread overview]
Message-ID: <493569D9.1030708@caviumnetworks.com> (raw)
In-Reply-To: <20081202112010.6b25af1c@lxorguk.ukuu.org.uk>
Alan Cox wrote:
> On Mon, 1 Dec 2008 15:49:25 -0800
> David Daney <ddaney@caviumnetworks.com> wrote:
>
>> In serial8250_isa_init_ports(), the port's lock is initialized. We
>> should not overwrite it. In early_serial_setup(), only copy in the
>> fields we need. Since the early console code only uses a subset of
>> the fields, these are sufficient.
>
>> - serial8250_ports[port->line].port.ops = &serial8250_pops;
>
> You seem to drop the assignment of port.ops ?
>
The port.ops are initialized in the preceding call to
serial8250_isa_init_ports(), we don't have to set it again as we are no
longer clobbering it with a full structure assignment.
Perhaps the patch commentary should be adjusted to mention this.
David Daney
next prev parent reply other threads:[~2008-12-02 17:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-01 23:46 [PATCH 0/4] serial: Patches for OCTEON CPU support (version 2) David Daney
2008-12-01 23:49 ` [PATCH 1/4] 8250: Don't clobber spinlocks David Daney
2008-12-02 11:20 ` Alan Cox
2008-12-02 17:01 ` David Daney [this message]
2008-12-01 23:49 ` [PATCH 2/4] 8250: Serial driver changes to support future Cavium OCTEON serial patches David Daney
2008-12-01 23:49 ` [PATCH 3/4] Serial: Allow port type to be specified when calling serial8250_register_port David Daney
2008-12-01 23:49 ` [PATCH 4/4] Serial: UART driver changes for Cavium OCTEON David Daney
2008-12-03 15:46 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=493569D9.1030708@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-mips@linux-mips.org \
--cc=linux-serial@vger.kernel.org \
--cc=tpaoletti@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox