From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paulius Zaleckas Subject: Re: [PATCH] drivers/serial/8250_pci.c (add support for '8-port RS-232 MIC-3620 from advantech' Date: Wed, 21 Jan 2009 10:18:05 +0200 Message-ID: <4976DA3D.7050201@teltonika.lt> References: <20090118135359.GA3087@deb-support.de> <20090119145101.GA16732@ports.donpac.ru> <20090119235122.GE21026@deb-support.de> <20090120151216.GB16732@ports.donpac.ru> <20090121075212.GA18485@deb-support.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from 81-7-68-229.static.zebra.lt ([81.7.68.229]:33213 "EHLO teltonika.lt" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751659AbZAUIYy (ORCPT ); Wed, 21 Jan 2009 03:24:54 -0500 In-Reply-To: <20090121075212.GA18485@deb-support.de> Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: Michael Bramer Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Alan Cox Michael Bramer wrote: > On Tue, Jan 20, 2009 at 06:12:16PM +0300, Andrey Panin wrote: >> On 019, 01 19, 2009 at 11:51:22PM +0000, Michael Bramer wrote: >>> On Mon, Jan 19, 2009 at 05:51:01PM +0300, Andrey Panin wrote: >>>> On 018, 01 18, 2009 at 01:53:59PM +0000, Michael Bramer wrote: >>>>> + * ADVANTECH >>>>> + */ >>>>> + { >>>>> + .vendor = PCI_VENDOR_ID_ADVANTECH, >>>>> + .device = PCI_DEVICE_ID_ADVANTECH_PCI3620, >>>>> + .subvendor = PCI_DEVICE_ID_ADVANTECH_PCI3620, >>>>> + .subdevice = PCI_ANY_ID, >>>>> + .setup = pci_default_setup, >>>>> + }, >>>>> + /* >>>>> * AFAVLAB cards - these may be called via parport_serial >>>>> * It is not clear whether this applies to all products. >>>>> */ >>>> This part is not needed at all, pci_default_setup() will be used by default. >>> ok. I don't test this. But you are right. The last entry in >>> pci_serial_quirks should catch it. >>> >>> Should I post a new patch, without this 10 lines? >> Yes and add Signed-off-by: line please. > > > the new patch: > -------------- > This Patch add the device information for the > MIC-3620 8-port RS-232 cPCI card from Advantech Co. Ltd. > > Signed-off-by: Michael Bramer > --- a/drivers/serial/8250_pci.c > +++ b/drivers/serial/8250_pci.c > @@ -31,6 +31,7 @@ > #include "8250.h" > > #undef SERIAL_DEBUG_PCI > +#define SERIAL_DEBUG_PCI NAK. > /* > * init function returns: > @@ -768,6 +769,8 @@ > #define PCI_SUBDEVICE_ID_OCTPRO422 0x0208 > #define PCI_SUBDEVICE_ID_POCTAL232 0x0308 > #define PCI_SUBDEVICE_ID_POCTAL422 0x0408 > +#define PCI_VENDOR_ID_ADVANTECH 0x13fe > +#define PCI_DEVICE_ID_ADVANTECH_PCI3620 0x3620 > > /* > * Master list of serial port init/setup/exit quirks. > @@ -2041,6 +2054,9 @@ > #endif > > static struct pci_device_id serial_pci_tbl[] = { > + { PCI_VENDOR_ID_ADVANTECH, PCI_DEVICE_ID_ADVANTECH_PCI3620, > + 0x3620, PCI_ANY_ID, 0, 0, > + pbn_b2_8_921600 }, > { PCI_VENDOR_ID_V3, PCI_DEVICE_ID_V3_V960, > PCI_SUBVENDOR_ID_CONNECT_TECH, > PCI_SUBDEVICE_ID_CONNECT_TECH_BH8_232, 0, 0, > -------------- > > Gruss > Grisu