Dear Linux-serial team

You are right about this IOCTL.

I agree that this should be solved in general.
We are using XR17D158, OX16D954 and XR16L788 chips.
I'm preparing patch that will enable auto mode (for RS485) on all of them.

In the meantime, could you accept patch without IOCTL? This will add
support for Meilhaus' boards (RS422 and RS485/422 in manual mode).

Best regards,
Krzysztof Gantzke

Laurent Pinchart wrote:
> On Monday 19 January 2009 16:10:32 Krzysztof Gantzke wrote:
>
>> Dear Linux-serial team
>> Meilhaus (PCI ID: 0x1402) ME90xx, ME91xx and ME93xx support added.
>> The are RS232 and RS422/485 PCI serial boards.
>> This patch was tested on x86 and x86_64 machines.
>>
>> Could you added this to main tree, please.
>>
>
> NAK. You should not add an ioctl to revert to RS232 mode but check
> serial_rs485.flags in TIOCSRS485. Enable RS485 when SER_RS485_ENABLED
is set,
> disable it otherwise.
>
> You should also probably base your patch to 8250.c on top of Matthias
Fuchs'
> patch ('[PATCH V3] serial: Add ioctl to enable auto rs485 mode with
some Exar
> UARTs').
>
> Best regards,
>
>


-- 
Krzysztof Gantzke

Meilhaus Electronic GmbH
Fischerstr. 2
D-82178 Puchheim