From: Yegor Yefremov <yegor_sub1@visionsystems.de>
To: linux-serial@vger.kernel.org
Subject: [atmel-serial] Fix compilation error caused by BUILD_BUG_ON() in 2.6.32-rc2 kernel
Date: Wed, 30 Sep 2009 10:25:33 +0200 [thread overview]
Message-ID: <4AC315FD.4060408@visionsystems.de> (raw)
Fix compilation error caused by BUILD_BUG_ON() in 2.6.32-rc2 kernel.
Add ring buffer size requirements to the macro definition instead of calling
BUILD_BUG_ON().
See the following thread for details:
http://www.gossamer-threads.com/lists/linux/kernel/1118447?page=last
Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
Index: linus2/drivers/serial/atmel_serial.c
===================================================================
--- linus2.orig/drivers/serial/atmel_serial.c
+++ linus2/drivers/serial/atmel_serial.c
@@ -123,6 +123,7 @@ struct atmel_uart_char {
u16 ch;
};
+/* the ring buffer size must be the power of 2 */
#define ATMEL_SERIAL_RINGSIZE 1024
/*
@@ -1531,8 +1532,6 @@ static int __devinit atmel_serial_probe(
void *data;
int ret;
- BUILD_BUG_ON(!is_power_of_2(ATMEL_SERIAL_RINGSIZE));
-
port = &atmel_ports[pdev->id];
port->backup_imr = 0;
reply other threads:[~2009-09-30 8:44 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AC315FD.4060408@visionsystems.de \
--to=yegor_sub1@visionsystems.de \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).