From: Jiri Slaby <jirislaby@gmail.com>
To: Sergei Organov <s.organov@javad.com>
Cc: linux-serial@vger.kernel.org
Subject: Re: Disregard: [PATCH] tty: Char: mxser, add support for CP114EL
Date: Tue, 02 Mar 2010 22:34:47 +0100 [thread overview]
Message-ID: <4B8D8477.8020003@gmail.com> (raw)
In-Reply-To: <87r5o24efj.fsf@osv.gnss.ru>
On 03/02/2010 10:11 PM, Sergei Organov wrote:
> Sergei Organov <osv@javad.com> writes:
>> Add support for MOXA:0x1144 pci device. It's a 4-port device and
>> differs in no way from the others. So this turns out to be a trivial
>> pci_device_id change.
>
> Please disregard this patch for now. This board doesn't in fact work
> properly with the driver and recognizing it by the driver might lead to
> problems.
>
> I'll be working on this, -- sorry for the noise.
Yeah, the device you have is handled by different driver which is not
upstream yet, If you really have the card, you can try to merge it and
cleanup e.g. through staging. Note that the driver provided by moxa is
ugly and needs cleanup before moving to drivers/char/. It might be worth
to merge it with mxser (I haven't look into how much similar/different
they are.).
next prev parent reply other threads:[~2010-03-02 21:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87bpf6esd7.fsf@osv.gnss.ru>
2010-03-02 21:11 ` Disregard: [PATCH] tty: Char: mxser, add support for CP114EL Sergei Organov
2010-03-02 21:34 ` Jiri Slaby [this message]
2010-03-03 11:11 ` Sergei Organov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B8D8477.8020003@gmail.com \
--to=jirislaby@gmail.com \
--cc=linux-serial@vger.kernel.org \
--cc=s.organov@javad.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).