Disregard: [PATCH] tty: Char: mxser, add support for CP114EL

Disregard: [PATCH] tty: Char: mxser, add support for CP114EL

[Sergei Organov]

Sergei Organov <osv@javad.com> writes:
> Add support for MOXA:0x1144 pci device. It's a 4-port device and
> differs in no way from the others. So this turns out to be a trivial
> pci_device_id change.

Please disregard this patch for now. This board doesn't in fact work
properly with the driver and recognizing it by the driver might lead to
problems.

I'll be working on this, -- sorry for the noise.

-- Sergei.

Re: Disregard: [PATCH] tty: Char: mxser, add support for CP114EL

[Jiri Slaby]

On 03/02/2010 10:11 PM, Sergei Organov wrote:
> Sergei Organov <osv@javad.com> writes:
>> Add support for MOXA:0x1144 pci device. It's a 4-port device and
>> differs in no way from the others. So this turns out to be a trivial
>> pci_device_id change.
> 
> Please disregard this patch for now. This board doesn't in fact work
> properly with the driver and recognizing it by the driver might lead to
> problems.
> 
> I'll be working on this, -- sorry for the noise.

Yeah, the device you have is handled by different driver which is not
upstream yet, If you really have the card, you can try to merge it and
cleanup e.g. through staging. Note that the driver provided by moxa is
ugly and needs cleanup before moving to drivers/char/. It might be worth
to merge it with mxser (I haven't look into how much similar/different
they are.).

Re: Disregard: [PATCH] tty: Char: mxser, add support for CP114EL

[Sergei Organov]

Jiri Slaby <jirislaby@gmail.com> writes:

> On 03/02/2010 10:11 PM, Sergei Organov wrote:
>> Sergei Organov <osv@javad.com> writes:
>>> Add support for MOXA:0x1144 pci device. It's a 4-port device and
>>> differs in no way from the others. So this turns out to be a trivial
>>> pci_device_id change.
>> 
>> Please disregard this patch for now. This board doesn't in fact work
>> properly with the driver and recognizing it by the driver might lead to
>> problems.
>> 
>> I'll be working on this, -- sorry for the noise.
>
> Yeah, the device you have is handled by different driver which is not
> upstream yet, If you really have the card, you can try to merge it and
> cleanup e.g. through staging. Note that the driver provided by moxa is
> ugly and needs cleanup before moving to drivers/char/. It might be worth
> to merge it with mxser (I haven't look into how much similar/different
> they are.).

Yeah, they seem to be similar, as I've almost got in-kernel driver to
work by looking at lspci output and making wild guesses, but then trying
to use /dev/ttyMI3 hang my PC.

I now compiled the driver provided by moxa and it works, so I now have a
code to refer to, and it has special-case for port 3 ;-) Unfortunately
their driver only supports kernels up to 2.6.30, so it will take
additional efforts to run it on recent.

I'm going to try to make in-kernel mxser to work with this board, --
will see how it goes.

-- Sergei.