linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Eric Bénard" <eric@eukrea.com>
To: linux-serial@vger.kernel.org
Subject: Re: serial/imx.c : wrong baudrate at resume if console is on UART
Date: Mon, 31 May 2010 09:33:07 +0200	[thread overview]
Message-ID: <4C036633.6070702@eukrea.com> (raw)
In-Reply-To: <4BFEDDD0.8000607@eukrea.com>

Hi,

Le 27/05/2010 23:02, Eric Bénard a écrit :
> while testing suspend/resume on i.MX27, I meet a problem on resume : if
> the console is on the UART the baudrate it not restored properly (I get
> random bitrate between 50 to 2Mbps). Here is a patch to add pm to the
> uart_ops (but the problem occurs also without this patch) :
> http://lists.infradead.org/pipermail/linux-arm-kernel/2010-May/016495.html
>
I've noticed that commenting out the following line in serial_core.c 
"fix" the problem :
diff --git a/drivers/serial/serial_core.c b/drivers/serial/serial_core.c
index 7f28307..c63476e 100644
--- a/drivers/serial/serial_core.c
+++ b/drivers/serial/serial_core.c
@@ -2092,7 +2092,7 @@ int uart_resume_port(struct uart_driver *drv, 
struct uart_
          */
         if (uart_console(uport)) {
                 uart_change_pm(state, 0);
-               uport->ops->set_termios(uport, &termios, NULL);
+//             uport->ops->set_termios(uport, &termios, NULL);
                 console_start(uport->cons);
         }

Do you have a hint of why the baudrate is not properly restored for the 
console or where I should dig to fix this in serial/imx.c ?

Thanks
Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      reply	other threads:[~2010-05-31  7:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-27 21:02 serial/imx.c : wrong baudrate at resume if console is on UART Eric Bénard
2010-05-31  7:33 ` Eric Bénard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C036633.6070702@eukrea.com \
    --to=eric@eukrea.com \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).