From: Paulius Zaleckas <paulius.zaleckas@gmail.com>
To: Kyungmin Park <kmpark@infradead.org>
Cc: Darius Augulis <augulis.darius@gmail.com>,
Joonyoung Shim <jy0922.shim@samsung.com>,
ben-linux@fluff.org, linux-arm-kernel@lists.infradead.org,
linux-serial@vger.kernel.org
Subject: Re: [PATCH] serial: samsung: fix device name
Date: Fri, 06 Aug 2010 09:47:18 +0300 [thread overview]
Message-ID: <4C5BAFF6.10606@gmail.com> (raw)
In-Reply-To: <AANLkTikp2ThBqF2jkU4CXS9-iYRoy3AWpeqWXjmLF6Gd@mail.gmail.com>
On 08/06/2010 03:04 AM, Kyungmin Park wrote:
> Hi,
>
> It's already posted by Mr. Shim
> http://marc.info/?l=linux-arm-kernel&m=127410047306149&w=2
Darius patch is a little bit cleaner.
> As discussed with Ben. even though it's right patch, there's some
> users to use previous interface.
> I also think it will be fixed. but need to coordinate with existing users.
IMO this is obvious bug fix.
Acked-by: Paulius Zaleckas <paulius.zaleckas@gmail.com>
> Ben, how to you think?
>
> On Fri, Aug 6, 2010 at 5:10 AM, Darius Augulis<augulis.darius@gmail.com> wrote:
>> Swap device and driver names in serial/samsung.c
>>
>> Signed-off-by: Darius Augulis<augulis.darius@gmail.com>
>> ---
>> drivers/serial/samsung.c | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/serial/samsung.c b/drivers/serial/samsung.c
>> index a9d6c56..9d63f24 100644
>> --- a/drivers/serial/samsung.c
>> +++ b/drivers/serial/samsung.c
>> @@ -878,10 +878,10 @@ static struct uart_ops s3c24xx_serial_ops = {
>>
>> static struct uart_driver s3c24xx_uart_drv = {
>> .owner = THIS_MODULE,
>> - .dev_name = "s3c2410_serial",
>> + .driver_name = "s3c2410_serial",
>> .nr = CONFIG_SERIAL_SAMSUNG_UARTS,
>> .cons = S3C24XX_SERIAL_CONSOLE,
>> - .driver_name = S3C24XX_SERIAL_NAME,
>> + .dev_name = S3C24XX_SERIAL_NAME,
>> .major = S3C24XX_SERIAL_MAJOR,
>> .minor = S3C24XX_SERIAL_MINOR,
>> };
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-serial" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2010-08-06 6:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-05 20:10 [PATCH] serial: samsung: fix device name Darius Augulis
2010-08-06 0:04 ` Kyungmin Park
2010-08-06 6:13 ` Darius Augulis
2010-08-06 6:26 ` Kyungmin Park
2010-08-06 6:47 ` Paulius Zaleckas [this message]
2010-08-06 7:06 ` Joonyoung Shim
2010-08-06 7:23 ` Kukjin Kim
2010-08-06 8:45 ` Paulius Zaleckas
2010-08-15 9:59 ` Darius Augulis
2010-08-30 7:05 ` Darius Augulis
2010-09-01 1:46 ` Kukjin Kim
2010-09-01 2:46 ` Joonyoung Shim
2010-09-01 6:27 ` Darius Augulis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C5BAFF6.10606@gmail.com \
--to=paulius.zaleckas@gmail.com \
--cc=augulis.darius@gmail.com \
--cc=ben-linux@fluff.org \
--cc=jy0922.shim@samsung.com \
--cc=kmpark@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).