From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paulius Zaleckas Subject: Re: [PATCH] serial: samsung: fix device name Date: Fri, 06 Aug 2010 09:47:18 +0300 Message-ID: <4C5BAFF6.10606@gmail.com> References: <20100805201000.14030.34703.stgit@darius-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Kyungmin Park Cc: Darius Augulis , Joonyoung Shim , ben-linux@fluff.org, linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org List-Id: linux-serial@vger.kernel.org On 08/06/2010 03:04 AM, Kyungmin Park wrote: > Hi, > > It's already posted by Mr. Shim > http://marc.info/?l=linux-arm-kernel&m=127410047306149&w=2 Darius patch is a little bit cleaner. > As discussed with Ben. even though it's right patch, there's some > users to use previous interface. > I also think it will be fixed. but need to coordinate with existing users. IMO this is obvious bug fix. Acked-by: Paulius Zaleckas > Ben, how to you think? > > On Fri, Aug 6, 2010 at 5:10 AM, Darius Augulis wrote: >> Swap device and driver names in serial/samsung.c >> >> Signed-off-by: Darius Augulis >> --- >> drivers/serial/samsung.c | 4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/serial/samsung.c b/drivers/serial/samsung.c >> index a9d6c56..9d63f24 100644 >> --- a/drivers/serial/samsung.c >> +++ b/drivers/serial/samsung.c >> @@ -878,10 +878,10 @@ static struct uart_ops s3c24xx_serial_ops = { >> >> static struct uart_driver s3c24xx_uart_drv = { >> .owner = THIS_MODULE, >> - .dev_name = "s3c2410_serial", >> + .driver_name = "s3c2410_serial", >> .nr = CONFIG_SERIAL_SAMSUNG_UARTS, >> .cons = S3C24XX_SERIAL_CONSOLE, >> - .driver_name = S3C24XX_SERIAL_NAME, >> + .dev_name = S3C24XX_SERIAL_NAME, >> .major = S3C24XX_SERIAL_MAJOR, >> .minor = S3C24XX_SERIAL_MINOR, >> }; >> >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-serial" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >