* [PATCH] serial: samsung: fix device name @ 2010-08-05 20:10 Darius Augulis 2010-08-06 0:04 ` Kyungmin Park 0 siblings, 1 reply; 13+ messages in thread From: Darius Augulis @ 2010-08-05 20:10 UTC (permalink / raw) To: linux-arm-kernel; +Cc: linux-serial, ben-linux Swap device and driver names in serial/samsung.c Signed-off-by: Darius Augulis <augulis.darius@gmail.com> --- drivers/serial/samsung.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/serial/samsung.c b/drivers/serial/samsung.c index a9d6c56..9d63f24 100644 --- a/drivers/serial/samsung.c +++ b/drivers/serial/samsung.c @@ -878,10 +878,10 @@ static struct uart_ops s3c24xx_serial_ops = { static struct uart_driver s3c24xx_uart_drv = { .owner = THIS_MODULE, - .dev_name = "s3c2410_serial", + .driver_name = "s3c2410_serial", .nr = CONFIG_SERIAL_SAMSUNG_UARTS, .cons = S3C24XX_SERIAL_CONSOLE, - .driver_name = S3C24XX_SERIAL_NAME, + .dev_name = S3C24XX_SERIAL_NAME, .major = S3C24XX_SERIAL_MAJOR, .minor = S3C24XX_SERIAL_MINOR, }; ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH] serial: samsung: fix device name 2010-08-05 20:10 [PATCH] serial: samsung: fix device name Darius Augulis @ 2010-08-06 0:04 ` Kyungmin Park 2010-08-06 6:13 ` Darius Augulis 2010-08-06 6:47 ` Paulius Zaleckas 0 siblings, 2 replies; 13+ messages in thread From: Kyungmin Park @ 2010-08-06 0:04 UTC (permalink / raw) To: Darius Augulis; +Cc: linux-arm-kernel, ben-linux, linux-serial, Joonyoung Shim Hi, It's already posted by Mr. Shim http://marc.info/?l=linux-arm-kernel&m=127410047306149&w=2 As discussed with Ben. even though it's right patch, there's some users to use previous interface. I also think it will be fixed. but need to coordinate with existing users. Ben, how to you think? On Fri, Aug 6, 2010 at 5:10 AM, Darius Augulis <augulis.darius@gmail.com> wrote: > Swap device and driver names in serial/samsung.c > > Signed-off-by: Darius Augulis <augulis.darius@gmail.com> > --- > drivers/serial/samsung.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/serial/samsung.c b/drivers/serial/samsung.c > index a9d6c56..9d63f24 100644 > --- a/drivers/serial/samsung.c > +++ b/drivers/serial/samsung.c > @@ -878,10 +878,10 @@ static struct uart_ops s3c24xx_serial_ops = { > > static struct uart_driver s3c24xx_uart_drv = { > .owner = THIS_MODULE, > - .dev_name = "s3c2410_serial", > + .driver_name = "s3c2410_serial", > .nr = CONFIG_SERIAL_SAMSUNG_UARTS, > .cons = S3C24XX_SERIAL_CONSOLE, > - .driver_name = S3C24XX_SERIAL_NAME, > + .dev_name = S3C24XX_SERIAL_NAME, > .major = S3C24XX_SERIAL_MAJOR, > .minor = S3C24XX_SERIAL_MINOR, > }; > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] serial: samsung: fix device name 2010-08-06 0:04 ` Kyungmin Park @ 2010-08-06 6:13 ` Darius Augulis 2010-08-06 6:26 ` Kyungmin Park 2010-08-06 6:47 ` Paulius Zaleckas 1 sibling, 1 reply; 13+ messages in thread From: Darius Augulis @ 2010-08-06 6:13 UTC (permalink / raw) To: Kyungmin Park; +Cc: Joonyoung Shim, ben-linux, linux-arm-kernel, linux-serial On 08/06/2010 03:04 AM, Kyungmin Park wrote: > Hi, > > It's already posted by Mr. Shim > http://marc.info/?l=linux-arm-kernel&m=127410047306149&w=2 > > As discussed with Ben. even though it's right patch, there's some > users to use previous interface. > I also think it will be fixed. but need to coordinate with existing users. > IMHO, it must be fixed. It's very annoying bug and I spend few hours trying to understand why kernel with devtmpfs auto-mount option doesn't provide ttySAC0, because when grep'ing 'grep -R ttySAC0 drivers/serial/* it's found in samsung driver and I thought everything should be o.k. Who could imagine that it's driver name, not device?... Regarding old users, they should not use such strange device name in their configs, they have to sync with main line. > Ben, how to you think? > > On Fri, Aug 6, 2010 at 5:10 AM, Darius Augulis<augulis.darius@gmail.com> wrote: >> Swap device and driver names in serial/samsung.c >> >> Signed-off-by: Darius Augulis<augulis.darius@gmail.com> >> --- >> drivers/serial/samsung.c | 4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/serial/samsung.c b/drivers/serial/samsung.c >> index a9d6c56..9d63f24 100644 >> --- a/drivers/serial/samsung.c >> +++ b/drivers/serial/samsung.c >> @@ -878,10 +878,10 @@ static struct uart_ops s3c24xx_serial_ops = { >> >> static struct uart_driver s3c24xx_uart_drv = { >> .owner = THIS_MODULE, >> - .dev_name = "s3c2410_serial", >> + .driver_name = "s3c2410_serial", >> .nr = CONFIG_SERIAL_SAMSUNG_UARTS, >> .cons = S3C24XX_SERIAL_CONSOLE, >> - .driver_name = S3C24XX_SERIAL_NAME, >> + .dev_name = S3C24XX_SERIAL_NAME, >> .major = S3C24XX_SERIAL_MAJOR, >> .minor = S3C24XX_SERIAL_MINOR, >> }; >> >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-serial" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] serial: samsung: fix device name 2010-08-06 6:13 ` Darius Augulis @ 2010-08-06 6:26 ` Kyungmin Park 0 siblings, 0 replies; 13+ messages in thread From: Kyungmin Park @ 2010-08-06 6:26 UTC (permalink / raw) To: Darius Augulis Cc: linux-arm-kernel, ben-linux, linux-serial, Joonyoung Shim, Kukjin Kim On Fri, Aug 6, 2010 at 3:13 PM, Darius Augulis <augulis.darius@gmail.com> wrote: > On 08/06/2010 03:04 AM, Kyungmin Park wrote: >> >> Hi, >> >> It's already posted by Mr. Shim >> http://marc.info/?l=linux-arm-kernel&m=127410047306149&w=2 >> >> As discussed with Ben. even though it's right patch, there's some >> users to use previous interface. >> I also think it will be fixed. but need to coordinate with existing users. >> > > IMHO, it must be fixed. It's very annoying bug and I spend few hours trying > to understand why kernel with devtmpfs auto-mount option doesn't provide > ttySAC0, because when grep'ing 'grep -R ttySAC0 drivers/serial/* > it's found in samsung driver and I thought everything should be o.k. Who > could imagine that it's driver name, not device?... > Regarding old users, they should not use such strange device name in their > configs, they have to sync with main line. Absolutely agree. > >> Ben, how to you think? >> >> On Fri, Aug 6, 2010 at 5:10 AM, Darius Augulis<augulis.darius@gmail.com> >> wrote: >>> >>> Swap device and driver names in serial/samsung.c >>> >>> Signed-off-by: Darius Augulis<augulis.darius@gmail.com> >>> --- >>> drivers/serial/samsung.c | 4 ++-- >>> 1 files changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/serial/samsung.c b/drivers/serial/samsung.c >>> index a9d6c56..9d63f24 100644 >>> --- a/drivers/serial/samsung.c >>> +++ b/drivers/serial/samsung.c >>> @@ -878,10 +878,10 @@ static struct uart_ops s3c24xx_serial_ops = { >>> >>> static struct uart_driver s3c24xx_uart_drv = { >>> .owner = THIS_MODULE, >>> - .dev_name = "s3c2410_serial", >>> + .driver_name = "s3c2410_serial", >>> .nr = CONFIG_SERIAL_SAMSUNG_UARTS, >>> .cons = S3C24XX_SERIAL_CONSOLE, >>> - .driver_name = S3C24XX_SERIAL_NAME, >>> + .dev_name = S3C24XX_SERIAL_NAME, >>> .major = S3C24XX_SERIAL_MAJOR, >>> .minor = S3C24XX_SERIAL_MINOR, >>> }; >>> >>> >>> _______________________________________________ >>> linux-arm-kernel mailing list >>> linux-arm-kernel@lists.infradead.org >>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >>> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-serial" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > > -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] serial: samsung: fix device name 2010-08-06 0:04 ` Kyungmin Park 2010-08-06 6:13 ` Darius Augulis @ 2010-08-06 6:47 ` Paulius Zaleckas 2010-08-06 7:06 ` Joonyoung Shim 1 sibling, 1 reply; 13+ messages in thread From: Paulius Zaleckas @ 2010-08-06 6:47 UTC (permalink / raw) To: Kyungmin Park Cc: Darius Augulis, Joonyoung Shim, ben-linux, linux-arm-kernel, linux-serial On 08/06/2010 03:04 AM, Kyungmin Park wrote: > Hi, > > It's already posted by Mr. Shim > http://marc.info/?l=linux-arm-kernel&m=127410047306149&w=2 Darius patch is a little bit cleaner. > As discussed with Ben. even though it's right patch, there's some > users to use previous interface. > I also think it will be fixed. but need to coordinate with existing users. IMO this is obvious bug fix. Acked-by: Paulius Zaleckas <paulius.zaleckas@gmail.com> > Ben, how to you think? > > On Fri, Aug 6, 2010 at 5:10 AM, Darius Augulis<augulis.darius@gmail.com> wrote: >> Swap device and driver names in serial/samsung.c >> >> Signed-off-by: Darius Augulis<augulis.darius@gmail.com> >> --- >> drivers/serial/samsung.c | 4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/serial/samsung.c b/drivers/serial/samsung.c >> index a9d6c56..9d63f24 100644 >> --- a/drivers/serial/samsung.c >> +++ b/drivers/serial/samsung.c >> @@ -878,10 +878,10 @@ static struct uart_ops s3c24xx_serial_ops = { >> >> static struct uart_driver s3c24xx_uart_drv = { >> .owner = THIS_MODULE, >> - .dev_name = "s3c2410_serial", >> + .driver_name = "s3c2410_serial", >> .nr = CONFIG_SERIAL_SAMSUNG_UARTS, >> .cons = S3C24XX_SERIAL_CONSOLE, >> - .driver_name = S3C24XX_SERIAL_NAME, >> + .dev_name = S3C24XX_SERIAL_NAME, >> .major = S3C24XX_SERIAL_MAJOR, >> .minor = S3C24XX_SERIAL_MINOR, >> }; >> >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-serial" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] serial: samsung: fix device name 2010-08-06 6:47 ` Paulius Zaleckas @ 2010-08-06 7:06 ` Joonyoung Shim 2010-08-06 7:23 ` Kukjin Kim 0 siblings, 1 reply; 13+ messages in thread From: Joonyoung Shim @ 2010-08-06 7:06 UTC (permalink / raw) To: Paulius Zaleckas Cc: Kyungmin Park, Darius Augulis, linux-arm-kernel, ben-linux, linux-serial On 8/6/2010 3:47 PM, Paulius Zaleckas wrote: > On 08/06/2010 03:04 AM, Kyungmin Park wrote: >> Hi, >> >> It's already posted by Mr. Shim >> http://marc.info/?l=linux-arm-kernel&m=127410047306149&w=2 > > Darius patch is a little bit cleaner. > OK, it's better. Acked-by: Joonyoung Shim <jy0922.shim@samsung.com> >> As discussed with Ben. even though it's right patch, there's some >> users to use previous interface. >> I also think it will be fixed. but need to coordinate with existing >> users. > > IMO this is obvious bug fix. > > Acked-by: Paulius Zaleckas <paulius.zaleckas@gmail.com> > >> Ben, how to you think? >> >> On Fri, Aug 6, 2010 at 5:10 AM, Darius >> Augulis<augulis.darius@gmail.com> wrote: >>> Swap device and driver names in serial/samsung.c >>> >>> Signed-off-by: Darius Augulis<augulis.darius@gmail.com> >>> --- >>> drivers/serial/samsung.c | 4 ++-- >>> 1 files changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/serial/samsung.c b/drivers/serial/samsung.c >>> index a9d6c56..9d63f24 100644 >>> --- a/drivers/serial/samsung.c >>> +++ b/drivers/serial/samsung.c >>> @@ -878,10 +878,10 @@ static struct uart_ops s3c24xx_serial_ops = { >>> >>> static struct uart_driver s3c24xx_uart_drv = { >>> .owner = THIS_MODULE, >>> - .dev_name = "s3c2410_serial", >>> + .driver_name = "s3c2410_serial", >>> .nr = CONFIG_SERIAL_SAMSUNG_UARTS, >>> .cons = S3C24XX_SERIAL_CONSOLE, >>> - .driver_name = S3C24XX_SERIAL_NAME, >>> + .dev_name = S3C24XX_SERIAL_NAME, >>> .major = S3C24XX_SERIAL_MAJOR, >>> .minor = S3C24XX_SERIAL_MINOR, >>> }; >>> >>> >>> _______________________________________________ >>> linux-arm-kernel mailing list >>> linux-arm-kernel@lists.infradead.org >>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >>> >> -- >> To unsubscribe from this list: send the line "unsubscribe >> linux-serial" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > > ^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: [PATCH] serial: samsung: fix device name 2010-08-06 7:06 ` Joonyoung Shim @ 2010-08-06 7:23 ` Kukjin Kim 2010-08-06 8:45 ` Paulius Zaleckas ` (2 more replies) 0 siblings, 3 replies; 13+ messages in thread From: Kukjin Kim @ 2010-08-06 7:23 UTC (permalink / raw) To: 'Joonyoung Shim', 'Paulius Zaleckas' Cc: 'Darius Augulis', 'Kyungmin Park', ben-linux, linux-arm-kernel, linux-serial Joonyoung Shim wrote: > > On 8/6/2010 3:47 PM, Paulius Zaleckas wrote: > > On 08/06/2010 03:04 AM, Kyungmin Park wrote: > >> Hi, > >> > >> It's already posted by Mr. Shim > >> http://marc.info/?l=linux-arm-kernel&m=127410047306149&w=2 > > > > Darius patch is a little bit cleaner. > > > > OK, it's better. > > Acked-by: Joonyoung Shim <jy0922.shim@samsung.com> > Hi all, I think, this should be handled by Ben Dooks.... As Kyungmin Park said, there was his comment about this. This is just for your information.... === On Tue, May 18, 2010 at 12:52:13PM +0900, Joonyoung Shim wrote: > On 5/18/2010 11:48 AM, Ben Dooks wrote: > > On Mon, May 17, 2010 at 09:46:50PM +0900, Joonyoung Shim wrote: > >> Thd dev_name and driver_name should be switched each other. > > > > Hmm, this doesn't seem to have appeard on the linux-arm-kernel list yet. > > > > Please provide some information about what problem that this is fixing > > and the impact on any existing systems. > > > > The serial device nodes are created to s3c2410_serial* on android > platform instead of ttySAC*. This has been how they've been for ages, surely the android device node creation sytstem supports symlinking /dev/SACx -> /dev/s3c2410_serialx, like many other operating sysyerms that can already do this. Changing this just because android (something as-yet unmerged into mainline) does not like it. I'm not even happy with an #ifdef around this. If you really feel this is a problem that you absolutely must fix in kernel then please provide a kernel commandline option to change the serial driver name and use that on any platform that needs it. Another way would be to update the serial platform data to have a field for which name to choose. -- Ben Q: What's a light-year? A: One-third less calories than a regular year. === > >> As discussed with Ben. even though it's right patch, there's some > >> users to use previous interface. > >> I also think it will be fixed. but need to coordinate with existing > >> users. > > > > IMO this is obvious bug fix. > > > > Acked-by: Paulius Zaleckas <paulius.zaleckas@gmail.com> > > > >> Ben, how to you think? > >> > >> On Fri, Aug 6, 2010 at 5:10 AM, Darius > >> Augulis<augulis.darius@gmail.com> wrote: > >>> Swap device and driver names in serial/samsung.c > >>> > >>> Signed-off-by: Darius Augulis<augulis.darius@gmail.com> > >>> --- > >>> drivers/serial/samsung.c | 4 ++-- > >>> 1 files changed, 2 insertions(+), 2 deletions(-) > >>> > >>> diff --git a/drivers/serial/samsung.c b/drivers/serial/samsung.c > >>> index a9d6c56..9d63f24 100644 > >>> --- a/drivers/serial/samsung.c > >>> +++ b/drivers/serial/samsung.c > >>> @@ -878,10 +878,10 @@ static struct uart_ops s3c24xx_serial_ops = { > >>> > >>> static struct uart_driver s3c24xx_uart_drv = { > >>> .owner = THIS_MODULE, > >>> - .dev_name = "s3c2410_serial", > >>> + .driver_name = "s3c2410_serial", > >>> .nr = CONFIG_SERIAL_SAMSUNG_UARTS, > >>> .cons = S3C24XX_SERIAL_CONSOLE, > >>> - .driver_name = S3C24XX_SERIAL_NAME, > >>> + .dev_name = S3C24XX_SERIAL_NAME, > >>> .major = S3C24XX_SERIAL_MAJOR, > >>> .minor = S3C24XX_SERIAL_MINOR, > >>> }; > >>> > >>> Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] serial: samsung: fix device name 2010-08-06 7:23 ` Kukjin Kim @ 2010-08-06 8:45 ` Paulius Zaleckas 2010-08-15 9:59 ` Darius Augulis 2010-08-30 7:05 ` Darius Augulis 2 siblings, 0 replies; 13+ messages in thread From: Paulius Zaleckas @ 2010-08-06 8:45 UTC (permalink / raw) To: Kukjin Kim Cc: 'Joonyoung Shim', 'Darius Augulis', 'Kyungmin Park', ben-linux, linux-arm-kernel, linux-serial On 08/06/2010 10:23 AM, Kukjin Kim wrote: > Joonyoung Shim wrote: >> >> On 8/6/2010 3:47 PM, Paulius Zaleckas wrote: >>> On 08/06/2010 03:04 AM, Kyungmin Park wrote: >>>> Hi, >>>> >>>> It's already posted by Mr. Shim >>>> http://marc.info/?l=linux-arm-kernel&m=127410047306149&w=2 >>> >>> Darius patch is a little bit cleaner. >>> >> >> OK, it's better. >> >> Acked-by: Joonyoung Shim<jy0922.shim@samsung.com> >> > > Hi all, > > I think, this should be handled by Ben Dooks.... > As Kyungmin Park said, there was his comment about this. > > This is just for your information.... > > === > > On Tue, May 18, 2010 at 12:52:13PM +0900, Joonyoung Shim wrote: >> On 5/18/2010 11:48 AM, Ben Dooks wrote: >>> On Mon, May 17, 2010 at 09:46:50PM +0900, Joonyoung Shim wrote: >>>> Thd dev_name and driver_name should be switched each other. >>> >>> Hmm, this doesn't seem to have appeard on the linux-arm-kernel list yet. >>> >>> Please provide some information about what problem that this is fixing >>> and the impact on any existing systems. >>> >> >> The serial device nodes are created to s3c2410_serial* on android >> platform instead of ttySAC*. > > This has been how they've been for ages, surely the android device node > creation sytstem supports symlinking /dev/SACx -> /dev/s3c2410_serialx, > like many other operating sysyerms that can already do this. > > Changing this just because android (something as-yet unmerged into mainline) > does not like it. I'm not even happy with an #ifdef around this. Not just android. Every linux user/developer is confused here... The first thing when I need to supply some application with serial port I type /dev/tty and press TAB couple times and in this case it FAILS. That is precisely the case Darius has spend couple days to realize that serial port is under same strange name s3c2410_serialx, even thou his CPU really is s3c6410! Even when I type in google "samsung console kernel", the first page I hit has information that it is under ttySACx name! > If you really feel this is a problem that you absolutely must fix in kernel > then please provide a kernel commandline option to change the serial driver > name and use that on any platform that needs it. Another way would be to > update the serial platform data to have a field for which name to choose. If there is need for old/broken name then userspace can create a symlink for this s3c2410_serial*. Udev can do this, static dev population can do this, init shell script can do this and many many other ways... Why should we put support for this broken name into kernel? My opinion would be to even send this patch to stable@vger.kernel.org ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] serial: samsung: fix device name 2010-08-06 7:23 ` Kukjin Kim 2010-08-06 8:45 ` Paulius Zaleckas @ 2010-08-15 9:59 ` Darius Augulis 2010-08-30 7:05 ` Darius Augulis 2 siblings, 0 replies; 13+ messages in thread From: Darius Augulis @ 2010-08-15 9:59 UTC (permalink / raw) To: Kukjin Kim, ben-linux Cc: linux-arm-kernel, 'Kyungmin Park', 'Joonyoung Shim', 'Paulius Zaleckas', linux-serial On 08/06/2010 10:23 AM, Kukjin Kim wrote: > Joonyoung Shim wrote: >> >> On 8/6/2010 3:47 PM, Paulius Zaleckas wrote: >>> On 08/06/2010 03:04 AM, Kyungmin Park wrote: >>>> Hi, >>>> >>>> It's already posted by Mr. Shim >>>> http://marc.info/?l=linux-arm-kernel&m=127410047306149&w=2 >>> >>> Darius patch is a little bit cleaner. >>> >> >> OK, it's better. >> >> Acked-by: Joonyoung Shim<jy0922.shim@samsung.com> >> > > Hi all, > > I think, this should be handled by Ben Dooks.... > As Kyungmin Park said, there was his comment about this. > Ben, what's your opinion about that? Are you going to merge that? > This is just for your information.... > > === > > On Tue, May 18, 2010 at 12:52:13PM +0900, Joonyoung Shim wrote: >> On 5/18/2010 11:48 AM, Ben Dooks wrote: >>> On Mon, May 17, 2010 at 09:46:50PM +0900, Joonyoung Shim wrote: >>>> Thd dev_name and driver_name should be switched each other. >>> >>> Hmm, this doesn't seem to have appeard on the linux-arm-kernel list yet. >>> >>> Please provide some information about what problem that this is fixing >>> and the impact on any existing systems. >>> >> >> The serial device nodes are created to s3c2410_serial* on android >> platform instead of ttySAC*. > > This has been how they've been for ages, surely the android device node > creation sytstem supports symlinking /dev/SACx -> /dev/s3c2410_serialx, > like many other operating sysyerms that can already do this. > > Changing this just because android (something as-yet unmerged into mainline) > does not like it. I'm not even happy with an #ifdef around this. > > If you really feel this is a problem that you absolutely must fix in kernel > then please provide a kernel commandline option to change the serial driver > name and use that on any platform that needs it. Another way would be to > update the serial platform data to have a field for which name to choose. > ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] serial: samsung: fix device name 2010-08-06 7:23 ` Kukjin Kim 2010-08-06 8:45 ` Paulius Zaleckas 2010-08-15 9:59 ` Darius Augulis @ 2010-08-30 7:05 ` Darius Augulis 2010-09-01 1:46 ` Kukjin Kim 2 siblings, 1 reply; 13+ messages in thread From: Darius Augulis @ 2010-08-30 7:05 UTC (permalink / raw) To: Kukjin Kim Cc: 'Joonyoung Shim', 'Paulius Zaleckas', 'Kyungmin Park', ben-linux, linux-arm-kernel, linux-serial Hi Kukjin, please pick up this one to your tree too. Thanks, Darius. On 08/06/2010 10:23 AM, Kukjin Kim wrote: > Joonyoung Shim wrote: >> >> On 8/6/2010 3:47 PM, Paulius Zaleckas wrote: >>> On 08/06/2010 03:04 AM, Kyungmin Park wrote: >>>> Hi, >>>> >>>> It's already posted by Mr. Shim >>>> http://marc.info/?l=linux-arm-kernel&m=127410047306149&w=2 >>> >>> Darius patch is a little bit cleaner. >>> >> >> OK, it's better. >> >> Acked-by: Joonyoung Shim<jy0922.shim@samsung.com> >> > > Hi all, > > I think, this should be handled by Ben Dooks.... > As Kyungmin Park said, there was his comment about this. > > This is just for your information.... > > === > > On Tue, May 18, 2010 at 12:52:13PM +0900, Joonyoung Shim wrote: >> On 5/18/2010 11:48 AM, Ben Dooks wrote: >>> On Mon, May 17, 2010 at 09:46:50PM +0900, Joonyoung Shim wrote: >>>> Thd dev_name and driver_name should be switched each other. >>> >>> Hmm, this doesn't seem to have appeard on the linux-arm-kernel list yet. >>> >>> Please provide some information about what problem that this is fixing >>> and the impact on any existing systems. >>> >> >> The serial device nodes are created to s3c2410_serial* on android >> platform instead of ttySAC*. > > This has been how they've been for ages, surely the android device node > creation sytstem supports symlinking /dev/SACx -> /dev/s3c2410_serialx, > like many other operating sysyerms that can already do this. > > Changing this just because android (something as-yet unmerged into mainline) > does not like it. I'm not even happy with an #ifdef around this. > > If you really feel this is a problem that you absolutely must fix in kernel > then please provide a kernel commandline option to change the serial driver > name and use that on any platform that needs it. Another way would be to > update the serial platform data to have a field for which name to choose. > ^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: [PATCH] serial: samsung: fix device name 2010-08-30 7:05 ` Darius Augulis @ 2010-09-01 1:46 ` Kukjin Kim 2010-09-01 2:46 ` Joonyoung Shim 2010-09-01 6:27 ` Darius Augulis 0 siblings, 2 replies; 13+ messages in thread From: Kukjin Kim @ 2010-09-01 1:46 UTC (permalink / raw) To: 'Darius Augulis' Cc: 'Joonyoung Shim', 'Paulius Zaleckas', 'Kyungmin Park', ben-linux, linux-arm-kernel, linux-serial Darius Augulis wrote: > > Hi Kukjin, > Hi ;-) > please pick up this one to your tree too. > As I still thinking, this should be handled by Ben Dooks. And please refer to below Ben's comments about this. > Thanks, > > Darius. > > On 08/06/2010 10:23 AM, Kukjin Kim wrote: > > Joonyoung Shim wrote: > >> > >> On 8/6/2010 3:47 PM, Paulius Zaleckas wrote: > >>> On 08/06/2010 03:04 AM, Kyungmin Park wrote: > >>>> Hi, > >>>> > >>>> It's already posted by Mr. Shim > >>>> http://marc.info/?l=linux-arm-kernel&m=127410047306149&w=2 > >>> > >>> Darius patch is a little bit cleaner. > >>> > >> > >> OK, it's better. > >> > >> Acked-by: Joonyoung Shim<jy0922.shim@samsung.com> > >> > > > > Hi all, > > > > I think, this should be handled by Ben Dooks.... > > As Kyungmin Park said, there was his comment about this. > > > > This is just for your information.... > > > > === > > > > On Tue, May 18, 2010 at 12:52:13PM +0900, Joonyoung Shim wrote: > >> On 5/18/2010 11:48 AM, Ben Dooks wrote: > >>> On Mon, May 17, 2010 at 09:46:50PM +0900, Joonyoung Shim wrote: > >>>> Thd dev_name and driver_name should be switched each other. > >>> > >>> Hmm, this doesn't seem to have appeard on the linux-arm-kernel list yet. > >>> > >>> Please provide some information about what problem that this is fixing > >>> and the impact on any existing systems. > >>> > >> > >> The serial device nodes are created to s3c2410_serial* on android > >> platform instead of ttySAC*. > > > > This has been how they've been for ages, surely the android device node > > creation sytstem supports symlinking /dev/SACx -> /dev/s3c2410_serialx, > > like many other operating sysyerms that can already do this. > > > > Changing this just because android (something as-yet unmerged into mainline) > > does not like it. I'm not even happy with an #ifdef around this. > > > > If you really feel this is a problem that you absolutely must fix in kernel > > then please provide a kernel commandline option to change the serial driver > > name and use that on any platform that needs it. Another way would be to > > update the serial platform data to have a field for which name to choose. > > Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] serial: samsung: fix device name 2010-09-01 1:46 ` Kukjin Kim @ 2010-09-01 2:46 ` Joonyoung Shim 2010-09-01 6:27 ` Darius Augulis 1 sibling, 0 replies; 13+ messages in thread From: Joonyoung Shim @ 2010-09-01 2:46 UTC (permalink / raw) To: Kukjin Kim Cc: 'Darius Augulis', 'Kyungmin Park', 'Paulius Zaleckas', ben-linux, linux-serial, linux-arm-kernel On 2010-09-01 오전 10:46, Kukjin Kim wrote: > Darius Augulis wrote: >> >> Hi Kukjin, >> > Hi ;-) > >> please pick up this one to your tree too. >> > > As I still thinking, this should be handled by Ben Dooks. > > And please refer to below Ben's comments about this. > I am really wondering your opinion about this fix. Why should handle only by Ben? This is obvious bug fix if you think so, you can handle it too. >> Thanks, >> >> Darius. >> >> On 08/06/2010 10:23 AM, Kukjin Kim wrote: >>> Joonyoung Shim wrote: >>>> >>>> On 8/6/2010 3:47 PM, Paulius Zaleckas wrote: >>>>> On 08/06/2010 03:04 AM, Kyungmin Park wrote: >>>>>> Hi, >>>>>> >>>>>> It's already posted by Mr. Shim >>>>>> http://marc.info/?l=linux-arm-kernel&m=127410047306149&w=2 >>>>> >>>>> Darius patch is a little bit cleaner. >>>>> >>>> >>>> OK, it's better. >>>> >>>> Acked-by: Joonyoung Shim<jy0922.shim@samsung.com> >>>> >>> >>> Hi all, >>> >>> I think, this should be handled by Ben Dooks.... >>> As Kyungmin Park said, there was his comment about this. >>> >>> This is just for your information.... >>> >>> === >>> >>> On Tue, May 18, 2010 at 12:52:13PM +0900, Joonyoung Shim wrote: >>>> On 5/18/2010 11:48 AM, Ben Dooks wrote: >>>>> On Mon, May 17, 2010 at 09:46:50PM +0900, Joonyoung Shim wrote: >>>>>> Thd dev_name and driver_name should be switched each other. >>>>> >>>>> Hmm, this doesn't seem to have appeard on the linux-arm-kernel list > yet. >>>>> >>>>> Please provide some information about what problem that this is fixing >>>>> and the impact on any existing systems. >>>>> >>>> >>>> The serial device nodes are created to s3c2410_serial* on android >>>> platform instead of ttySAC*. >>> >>> This has been how they've been for ages, surely the android device node >>> creation sytstem supports symlinking /dev/SACx -> /dev/s3c2410_serialx, >>> like many other operating sysyerms that can already do this. >>> >>> Changing this just because android (something as-yet unmerged into > mainline) >>> does not like it. I'm not even happy with an #ifdef around this. >>> >>> If you really feel this is a problem that you absolutely must fix in > kernel >>> then please provide a kernel commandline option to change the serial > driver >>> name and use that on any platform that needs it. Another way would be to >>> update the serial platform data to have a field for which name to > choose. >>> > > > Thanks. > > Best regards, > Kgene. > -- > Kukjin Kim<kgene.kim@samsung.com>, Senior Engineer, > SW Solution Development Team, Samsung Electronics Co., Ltd. > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] serial: samsung: fix device name 2010-09-01 1:46 ` Kukjin Kim 2010-09-01 2:46 ` Joonyoung Shim @ 2010-09-01 6:27 ` Darius Augulis 1 sibling, 0 replies; 13+ messages in thread From: Darius Augulis @ 2010-09-01 6:27 UTC (permalink / raw) To: Kukjin Kim Cc: Joonyoung Shim, Paulius Zaleckas, Kyungmin Park, ben-linux, linux-arm-kernel, linux-serial On Wed, Sep 1, 2010 at 4:46 AM, Kukjin Kim <kgene.kim@samsung.com> wrote: > Darius Augulis wrote: >> >> Hi Kukjin, >> > Hi ;-) > >> please pick up this one to your tree too. >> > > As I still thinking, this should be handled by Ben Dooks. > > And please refer to below Ben's comments about this. there isn't anything to handle. it's few lines patch, we type more lines to discuss it. this patch hangs there for almost half year. we waste time. > >> Thanks, >> >> Darius. >> >> On 08/06/2010 10:23 AM, Kukjin Kim wrote: >> > Joonyoung Shim wrote: >> >> >> >> On 8/6/2010 3:47 PM, Paulius Zaleckas wrote: >> >>> On 08/06/2010 03:04 AM, Kyungmin Park wrote: >> >>>> Hi, >> >>>> >> >>>> It's already posted by Mr. Shim >> >>>> http://marc.info/?l=linux-arm-kernel&m=127410047306149&w=2 >> >>> >> >>> Darius patch is a little bit cleaner. >> >>> >> >> >> >> OK, it's better. >> >> >> >> Acked-by: Joonyoung Shim<jy0922.shim@samsung.com> >> >> >> > >> > Hi all, >> > >> > I think, this should be handled by Ben Dooks.... >> > As Kyungmin Park said, there was his comment about this. >> > >> > This is just for your information.... >> > >> > === >> > >> > On Tue, May 18, 2010 at 12:52:13PM +0900, Joonyoung Shim wrote: >> >> On 5/18/2010 11:48 AM, Ben Dooks wrote: >> >>> On Mon, May 17, 2010 at 09:46:50PM +0900, Joonyoung Shim wrote: >> >>>> Thd dev_name and driver_name should be switched each other. >> >>> >> >>> Hmm, this doesn't seem to have appeard on the linux-arm-kernel list > yet. >> >>> >> >>> Please provide some information about what problem that this is fixing >> >>> and the impact on any existing systems. >> >>> >> >> >> >> The serial device nodes are created to s3c2410_serial* on android >> >> platform instead of ttySAC*. >> > >> > This has been how they've been for ages, surely the android device node >> > creation sytstem supports symlinking /dev/SACx -> /dev/s3c2410_serialx, >> > like many other operating sysyerms that can already do this. >> > >> > Changing this just because android (something as-yet unmerged into > mainline) >> > does not like it. I'm not even happy with an #ifdef around this. >> > >> > If you really feel this is a problem that you absolutely must fix in > kernel >> > then please provide a kernel commandline option to change the serial > driver >> > name and use that on any platform that needs it. Another way would be to >> > update the serial platform data to have a field for which name to > choose. >> > > > > Thanks. > > Best regards, > Kgene. > -- > Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer, > SW Solution Development Team, Samsung Electronics Co., Ltd. > > -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2010-09-01 6:27 UTC | newest] Thread overview: 13+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2010-08-05 20:10 [PATCH] serial: samsung: fix device name Darius Augulis 2010-08-06 0:04 ` Kyungmin Park 2010-08-06 6:13 ` Darius Augulis 2010-08-06 6:26 ` Kyungmin Park 2010-08-06 6:47 ` Paulius Zaleckas 2010-08-06 7:06 ` Joonyoung Shim 2010-08-06 7:23 ` Kukjin Kim 2010-08-06 8:45 ` Paulius Zaleckas 2010-08-15 9:59 ` Darius Augulis 2010-08-30 7:05 ` Darius Augulis 2010-09-01 1:46 ` Kukjin Kim 2010-09-01 2:46 ` Joonyoung Shim 2010-09-01 6:27 ` Darius Augulis
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).