From: Jason Wang <jason77.wang@gmail.com>
To: Stanislav Brabec <sbrabec@suse.cz>
Cc: jason wang <jason77.wang@gmail.com>,
gregkh@suse.de, alan@linux.intel.com, arnd@arndb.de,
linux-serial@vger.kernel.org
Subject: Re: [PATCH RESEND 0/2] two serial_core suspend/resume fixes
Date: Thu, 26 Aug 2010 16:50:36 +0800 [thread overview]
Message-ID: <4C762ADC.8080309@gmail.com> (raw)
In-Reply-To: <1282766435.5085.178.camel@utx.lan>
Stanislav Brabec wrote:
> Stanislav Brabec wrote:
>
>> wanghui wrote:
>>
>>> For this situation, i guess you use a single serial port both as a
>>> printk console and as a login tty.
>>>
>> Yes, I did exactly that.
>>
>
> Well, I just succeeded with experiments.
> Changing
> if (console_suspend_enabled || !uart_console(uport)) {
> in resume process just above the line
> /* Protected by port mutex for now */
> to
> if (1) {
> makes resume working with no_console_suspend again. So one of lines
> inside does something important.
>
> Even then, the log is incomplete. dmesg shows more, but even it lacks
> printk output from inside of if (1).
>
>
Hah, :), i guess the ops->set_termios() resume your uart in the end.
Why lost some logs, i will try to reproduce your test.
next prev parent reply other threads:[~2010-08-26 8:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-21 7:14 [PATCH RESEND 0/2] two serial_core suspend/resume fixes Jason Wang
2010-08-21 7:14 ` [PATCH RESEND 1/2] serial-core: skip call set_termios/console_start when no_console_suspend Jason Wang
2010-08-21 7:14 ` [PATCH RESEND 2/2] serial-core: restore termios settings when resume console ports Jason Wang
2010-08-23 20:06 ` [PATCH RESEND 0/2] two serial_core suspend/resume fixes Stanislav Brabec
[not found] ` <AANLkTikZgAMvODoFB9O9Mrb98f_xMatQfkb+2dgcrGJn@mail.gmail.com>
2010-08-24 9:01 ` Stanislav Brabec
2010-08-25 3:29 ` wanghui
2010-08-25 10:51 ` Stanislav Brabec
2010-08-25 20:00 ` Stanislav Brabec
2010-08-26 8:50 ` Jason Wang [this message]
2010-08-29 22:17 ` Stanislav Brabec
2010-08-30 5:59 ` Jason Wang
2010-08-26 8:36 ` Jason Wang
2010-08-26 10:55 ` Stanislav Brabec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C762ADC.8080309@gmail.com \
--to=jason77.wang@gmail.com \
--cc=alan@linux.intel.com \
--cc=arnd@arndb.de \
--cc=gregkh@suse.de \
--cc=linux-serial@vger.kernel.org \
--cc=sbrabec@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).