From: Claudio Scordino <claudio@evidence.eu.com>
To: Jesper Nilsson <jesper.nilsson@axis.com>
Cc: starvik@axis.com, linux-cris-kernel <linux-cris-kernel@axis.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
Hinko Kocevar <hinko.kocevar@cetrtapot.si>,
Janez Cufer <janez.cufer@cetrtapot.si>,
Andy Whitcroft <apw@canonical.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
dev-etrax <dev-etrax@axis.com>,
linux-serial@vger.kernel.org
Subject: Re: [PATCH] CRIS RS485: Check SER_RS485_RTS_BEFORE_SEND before delaying.
Date: Mon, 30 Aug 2010 10:32:27 +0200 [thread overview]
Message-ID: <4C7B6C9B.2050801@evidence.eu.com> (raw)
In-Reply-To: <4C62BD2B.2010508@evidence.eu.com>
Claudio Scordino ha scritto:
> Hi Jesper,
>
> the following patch fixes the usage of the delay in RS485 mode
> on the Cris architecture.
>
> Very recently, the RS485 interface has been fixed by adding two further
> fields (see commit 1b6331848b69d1ed165a6bdc75c4046d68767563).
>
> This patch checks the value of the flag SER_RS485_RTS_BEFORE_SEND before
> delaying.
Hi all,
so far I didn't receive any acknowledgement about this patch.
As I said, recently (see commit 1b6331848b69d1ed165a6bdc75c4046d68767563) the
Linux RS485 interface has been fixed by adding two missing fields.
With the "new" interface, you have to check the SER_RS485_RTS_BEFORE_SEND flag
before using the delay_rts_before_send field.
The Atmel serial driver has been already fixed (with commit
1b6331848b69d1ed165a6bdc75c4046d68767563 itself).
This patch fixes the usage of the interface in the Cris driver too.
Best regards,
Claudio
next prev parent reply other threads:[~2010-08-30 8:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-11 15:09 [PATCH] CRIS RS485: Check SER_RS485_RTS_BEFORE_SEND before delaying Claudio Scordino
2010-08-30 8:32 ` Claudio Scordino [this message]
2010-08-30 8:39 ` Mikael Starvik
2010-10-19 12:34 ` Claudio Scordino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C7B6C9B.2050801@evidence.eu.com \
--to=claudio@evidence.eu.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=apw@canonical.com \
--cc=dev-etrax@axis.com \
--cc=hinko.kocevar@cetrtapot.si \
--cc=janez.cufer@cetrtapot.si \
--cc=jesper.nilsson@axis.com \
--cc=linux-cris-kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=starvik@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).