* [RESEND PATCH] serial: samsung: fix device name @ 2010-09-23 19:15 Darius Augulis 2010-09-23 19:40 ` Wolfram Sang 2010-09-23 23:40 ` Ben Dooks 0 siblings, 2 replies; 13+ messages in thread From: Darius Augulis @ 2010-09-23 19:15 UTC (permalink / raw) To: linux-arm-kernel Cc: kgene.kim, paulius.zaleckas, linux-kernel, ben-linux, linux-serial Swap device and driver names in serial/samsung.c Signed-off-by: Darius Augulis <augulis.darius@gmail.com> --- This patch was submitted about 3 months ago, but still not merged. There was another similar patch from Joonyoung Shim <jy0922.shim@samsung.com> and was discussed here: http://marc.info/?l=linux-serial&m=127416101222281&w=2. Joonyoung Shim acked my patch and other people on ARM mailing list acked it. The maintainer, Ben Dooks, still not responding for a long time. Another maintainer, Kukjin Kim, refused to merge it without Ben's review. I would like to ask somebody pick up this bugfix. drivers/serial/samsung.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/serial/samsung.c b/drivers/serial/samsung.c index b1156ba..25c0d0f 100644 --- a/drivers/serial/samsung.c +++ b/drivers/serial/samsung.c @@ -883,10 +883,10 @@ static struct uart_ops s3c24xx_serial_ops = { static struct uart_driver s3c24xx_uart_drv = { .owner = THIS_MODULE, - .dev_name = "s3c2410_serial", + .driver_name = "s3c2410_serial", .nr = CONFIG_SERIAL_SAMSUNG_UARTS, .cons = S3C24XX_SERIAL_CONSOLE, - .driver_name = S3C24XX_SERIAL_NAME, + .dev_name = S3C24XX_SERIAL_NAME, .major = S3C24XX_SERIAL_MAJOR, .minor = S3C24XX_SERIAL_MINOR, }; ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [RESEND PATCH] serial: samsung: fix device name 2010-09-23 19:15 [RESEND PATCH] serial: samsung: fix device name Darius Augulis @ 2010-09-23 19:40 ` Wolfram Sang 2010-09-23 23:40 ` Ben Dooks 1 sibling, 0 replies; 13+ messages in thread From: Wolfram Sang @ 2010-09-23 19:40 UTC (permalink / raw) To: Darius Augulis Cc: linux-arm-kernel, kgene.kim, paulius.zaleckas, linux-kernel, ben-linux, linux-serial [-- Attachment #1: Type: text/plain, Size: 1935 bytes --] On Thu, Sep 23, 2010 at 10:15:31PM +0300, Darius Augulis wrote: > Swap device and driver names in serial/samsung.c > > Signed-off-by: Darius Augulis <augulis.darius@gmail.com> > --- > > This patch was submitted about 3 months ago, but still not merged. > There was another similar patch from Joonyoung Shim > <jy0922.shim@samsung.com> and was discussed here: > http://marc.info/?l=linux-serial&m=127416101222281&w=2. > Joonyoung Shim acked my patch and other people on ARM mailing list > acked it. The maintainer, Ben Dooks, still not responding for Why didn't you add the ACKs to your patch? That will look more convincing for the one picking it up. > a long time. Another maintainer, Kukjin Kim, refused to merge > it without Ben's review. > I would like to ask somebody pick up this bugfix. > > drivers/serial/samsung.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/serial/samsung.c b/drivers/serial/samsung.c > index b1156ba..25c0d0f 100644 > --- a/drivers/serial/samsung.c > +++ b/drivers/serial/samsung.c > @@ -883,10 +883,10 @@ static struct uart_ops s3c24xx_serial_ops = { > > static struct uart_driver s3c24xx_uart_drv = { > .owner = THIS_MODULE, > - .dev_name = "s3c2410_serial", > + .driver_name = "s3c2410_serial", > .nr = CONFIG_SERIAL_SAMSUNG_UARTS, > .cons = S3C24XX_SERIAL_CONSOLE, > - .driver_name = S3C24XX_SERIAL_NAME, > + .dev_name = S3C24XX_SERIAL_NAME, > .major = S3C24XX_SERIAL_MAJOR, > .minor = S3C24XX_SERIAL_MINOR, > }; > > -- > To unsubscribe from this list: send the line "unsubscribe linux-serial" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 197 bytes --] ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RESEND PATCH] serial: samsung: fix device name 2010-09-23 19:15 [RESEND PATCH] serial: samsung: fix device name Darius Augulis 2010-09-23 19:40 ` Wolfram Sang @ 2010-09-23 23:40 ` Ben Dooks 2010-09-24 6:57 ` Darius Augulis 1 sibling, 1 reply; 13+ messages in thread From: Ben Dooks @ 2010-09-23 23:40 UTC (permalink / raw) To: Darius Augulis Cc: linux-arm-kernel, kgene.kim, ben-linux, linux-kernel, paulius.zaleckas, linux-serial On 23/09/10 20:15, Darius Augulis wrote: > Swap device and driver names in serial/samsung.c This is far too short, please see the notes below on trying to make this more informative. > Signed-off-by: Darius Augulis <augulis.darius@gmail.com> > --- > > This patch was submitted about 3 months ago, but still not merged. > There was another similar patch from Joonyoung Shim > <jy0922.shim@samsung.com> and was discussed here: > http://marc.info/?l=linux-serial&m=127416101222281&w=2. > Joonyoung Shim acked my patch and other people on ARM mailing list > acked it. The maintainer, Ben Dooks, still not responding for > a long time. Another maintainer, Kukjin Kim, refused to merge > it without Ben's review. > I would like to ask somebody pick up this bugfix. I belive last time this was brought up I asked about the affect this has on the userspace. The following issues would be helpful or essential to have noted in the header about the effect of this. - Does it change the /dev name of the device? if so I would thinl carefully about applying it, as it would be a change in the way that userspace sees the kernel. - Does it change the kernel output itself? A note on what diffeences can be seen in things like dmesg would be helpful. - Are there any other side effects - Why is this a bug? Maybe the previous points will explain what is going on, but if not, then a reasonably concise description of what is going on here. > drivers/serial/samsung.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/serial/samsung.c b/drivers/serial/samsung.c > index b1156ba..25c0d0f 100644 > --- a/drivers/serial/samsung.c > +++ b/drivers/serial/samsung.c > @@ -883,10 +883,10 @@ static struct uart_ops s3c24xx_serial_ops = { > > static struct uart_driver s3c24xx_uart_drv = { > .owner = THIS_MODULE, > - .dev_name = "s3c2410_serial", > + .driver_name = "s3c2410_serial", > .nr = CONFIG_SERIAL_SAMSUNG_UARTS, > .cons = S3C24XX_SERIAL_CONSOLE, > - .driver_name = S3C24XX_SERIAL_NAME, > + .dev_name = S3C24XX_SERIAL_NAME, > .major = S3C24XX_SERIAL_MAJOR, > .minor = S3C24XX_SERIAL_MINOR, > }; > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RESEND PATCH] serial: samsung: fix device name 2010-09-23 23:40 ` Ben Dooks @ 2010-09-24 6:57 ` Darius Augulis 2010-09-24 7:34 ` Simon Richter 2010-09-24 16:37 ` Paulius Zaleckas 0 siblings, 2 replies; 13+ messages in thread From: Darius Augulis @ 2010-09-24 6:57 UTC (permalink / raw) To: Ben Dooks Cc: linux-arm-kernel, kgene.kim, linux-kernel, paulius.zaleckas, linux-serial Hi, On Fri, Sep 24, 2010 at 2:40 AM, Ben Dooks <ben-linux@fluff.org> wrote: > On 23/09/10 20:15, Darius Augulis wrote: >> Swap device and driver names in serial/samsung.c > > This is far too short, please see the notes below on trying > to make this more informative. > >> Signed-off-by: Darius Augulis <augulis.darius@gmail.com> >> --- >> >> This patch was submitted about 3 months ago, but still not merged. >> There was another similar patch from Joonyoung Shim >> <jy0922.shim@samsung.com> and was discussed here: >> http://marc.info/?l=linux-serial&m=127416101222281&w=2. >> Joonyoung Shim acked my patch and other people on ARM mailing list >> acked it. The maintainer, Ben Dooks, still not responding for >> a long time. Another maintainer, Kukjin Kim, refused to merge >> it without Ben's review. >> I would like to ask somebody pick up this bugfix. > > I belive last time this was brought up I asked about the affect > this has on the userspace. The following issues would be helpful > or essential to have noted in the header about the effect of this. > > - Does it change the /dev name of the device? if so I would thinl > carefully about applying it, as it would be a change in the way > that userspace sees the kernel. It does - now devices are named /dev/s3c2410_serial, and patch changes its name to /dev/ttySAC > > - Does it change the kernel output itself? A note on what diffeences > can be seen in things like dmesg would be helpful. It does. Serial driver reports device names when probing, so there will appear ttySACx instead of s3c2410_serialx. > > - Are there any other side effects > > - Why is this a bug? Maybe the previous points will explain what is > going on, but if not, then a reasonably concise description of > what is going on here. This is bug, because of several points: 1. Because it contradicts kernel documentation. Please read Documentation/arm/Samsung-S3C24XX/Overview.txt line 196. This should be enough to apply this patch. 2. Because s3c2410_serial isn't correct name for serial device node. It's name of Samsung serial driver. 3. Because now almost all userspace systems workaround it by creating symlink /dev/ttySACx > /dev/s3c2410_serialx and only then put some getty on created symlink, not on original device. Systems which don't create this symlink, fail to boot at all, because of wrong console name. Good example is Buildroot. > >> drivers/serial/samsung.c | 4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/serial/samsung.c b/drivers/serial/samsung.c >> index b1156ba..25c0d0f 100644 >> --- a/drivers/serial/samsung.c >> +++ b/drivers/serial/samsung.c >> @@ -883,10 +883,10 @@ static struct uart_ops s3c24xx_serial_ops = { >> >> static struct uart_driver s3c24xx_uart_drv = { >> .owner = THIS_MODULE, >> - .dev_name = "s3c2410_serial", >> + .driver_name = "s3c2410_serial", >> .nr = CONFIG_SERIAL_SAMSUNG_UARTS, >> .cons = S3C24XX_SERIAL_CONSOLE, >> - .driver_name = S3C24XX_SERIAL_NAME, >> + .dev_name = S3C24XX_SERIAL_NAME, >> .major = S3C24XX_SERIAL_MAJOR, >> .minor = S3C24XX_SERIAL_MINOR, >> }; >> >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > > -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RESEND PATCH] serial: samsung: fix device name 2010-09-24 6:57 ` Darius Augulis @ 2010-09-24 7:34 ` Simon Richter 2010-09-24 7:42 ` Russell King - ARM Linux 2010-09-27 0:17 ` Ben Dooks 2010-09-24 16:37 ` Paulius Zaleckas 1 sibling, 2 replies; 13+ messages in thread From: Simon Richter @ 2010-09-24 7:34 UTC (permalink / raw) To: Darius Augulis Cc: kgene.kim, Ben Dooks, paulius.zaleckas, linux-kernel, linux-serial, linux-arm-kernel Hi, On Fri, Sep 24, 2010 at 09:57:19AM +0300, Darius Augulis wrote: > It does - now devices are named /dev/s3c2410_serial, and patch changes > its name to /dev/ttySAC I wonder if it'd make sense to name them ttyS[0-9]. I've never understood why the platform standard fixed serial ports on any device should have a different name. Simon ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RESEND PATCH] serial: samsung: fix device name 2010-09-24 7:34 ` Simon Richter @ 2010-09-24 7:42 ` Russell King - ARM Linux 2010-09-27 0:17 ` Ben Dooks 1 sibling, 0 replies; 13+ messages in thread From: Russell King - ARM Linux @ 2010-09-24 7:42 UTC (permalink / raw) To: Simon Richter Cc: Darius Augulis, kgene.kim, Ben Dooks, paulius.zaleckas, linux-kernel, linux-serial, linux-arm-kernel On Fri, Sep 24, 2010 at 09:34:53AM +0200, Simon Richter wrote: > Hi, > > On Fri, Sep 24, 2010 at 09:57:19AM +0300, Darius Augulis wrote: > > > It does - now devices are named /dev/s3c2410_serial, and patch changes > > its name to /dev/ttySAC > > I wonder if it'd make sense to name them ttyS[0-9]. I've never > understood why the platform standard fixed serial ports on any device > should have a different name. It's called namespace. If platform serial ports are different, then they have to have a separate namespace otherwise things like console= end up having to have a separate namespace from the one which the user sees in the filesystem. Moreover, you introduce a bunch of special cases into the 8250 serial driver - or you simply exclude the 8250 serial driver being used on a platform. ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RESEND PATCH] serial: samsung: fix device name 2010-09-24 7:34 ` Simon Richter 2010-09-24 7:42 ` Russell King - ARM Linux @ 2010-09-27 0:17 ` Ben Dooks 1 sibling, 0 replies; 13+ messages in thread From: Ben Dooks @ 2010-09-27 0:17 UTC (permalink / raw) To: Simon Richter Cc: Darius Augulis, kgene.kim, Ben Dooks, paulius.zaleckas, linux-kernel, linux-serial, linux-arm-kernel On 24/09/10 08:34, Simon Richter wrote: > Hi, > > On Fri, Sep 24, 2010 at 09:57:19AM +0300, Darius Augulis wrote: > >> It does - now devices are named /dev/s3c2410_serial, and patch changes >> its name to /dev/ttySAC > > I wonder if it'd make sense to name them ttyS[0-9]. I've never > understood why the platform standard fixed serial ports on any device > should have a different name. Different driver. And yes, we've built systems with both this and an 8250 base chip. ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RESEND PATCH] serial: samsung: fix device name 2010-09-24 6:57 ` Darius Augulis 2010-09-24 7:34 ` Simon Richter @ 2010-09-24 16:37 ` Paulius Zaleckas 2010-09-27 0:18 ` Ben Dooks 1 sibling, 1 reply; 13+ messages in thread From: Paulius Zaleckas @ 2010-09-24 16:37 UTC (permalink / raw) To: Darius Augulis Cc: kgene.kim, linux-serial, linux-arm-kernel, Ben Dooks, linux-kernel On 09/24/2010 09:57 AM, Darius Augulis wrote: > Hi, > > On Fri, Sep 24, 2010 at 2:40 AM, Ben Dooks<ben-linux@fluff.org> wrote: >> On 23/09/10 20:15, Darius Augulis wrote: >>> Swap device and driver names in serial/samsung.c >> >> This is far too short, please see the notes below on trying >> to make this more informative. >> >>> Signed-off-by: Darius Augulis<augulis.darius@gmail.com> >>> --- >>> >>> This patch was submitted about 3 months ago, but still not merged. >>> There was another similar patch from Joonyoung Shim >>> <jy0922.shim@samsung.com> and was discussed here: >>> http://marc.info/?l=linux-serial&m=127416101222281&w=2. >>> Joonyoung Shim acked my patch and other people on ARM mailing list >>> acked it. The maintainer, Ben Dooks, still not responding for >>> a long time. Another maintainer, Kukjin Kim, refused to merge >>> it without Ben's review. >>> I would like to ask somebody pick up this bugfix. >> >> I belive last time this was brought up I asked about the affect >> this has on the userspace. The following issues would be helpful >> or essential to have noted in the header about the effect of this. >> >> - Does it change the /dev name of the device? if so I would thinl >> carefully about applying it, as it would be a change in the way >> that userspace sees the kernel. > > It does - now devices are named /dev/s3c2410_serial, and patch changes > its name to /dev/ttySAC > >> >> - Does it change the kernel output itself? A note on what diffeences >> can be seen in things like dmesg would be helpful. > > It does. Serial driver reports device names when probing, so there > will appear ttySACx instead of > s3c2410_serialx. > >> >> - Are there any other side effects >> >> - Why is this a bug? Maybe the previous points will explain what is >> going on, but if not, then a reasonably concise description of >> what is going on here. > > This is bug, because of several points: > > 1. Because it contradicts kernel documentation. Please read > Documentation/arm/Samsung-S3C24XX/Overview.txt line 196. > This should be enough to apply this patch. > > 2. Because s3c2410_serial isn't correct name for serial device node. > It's name of Samsung serial driver. > > 3. Because now almost all userspace systems workaround it by creating symlink > /dev/ttySACx> /dev/s3c2410_serialx and only then put some getty on > created symlink, not on original device. > Systems which don't create this symlink, fail to boot at all, because > of wrong console name. Good example is Buildroot. I had similar issue with buildroot too, because in /etc/securetty it is defained as ttySAC0 4. For console in kernel boot command line you must enter console=ttySACx. Why it sould be different in userspace? For me it seems taht this bug was not noticed earlier, because most embedded systems were using static device nodes and ttySACx was used in these cases. >> >>> drivers/serial/samsung.c | 4 ++-- >>> 1 files changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/serial/samsung.c b/drivers/serial/samsung.c >>> index b1156ba..25c0d0f 100644 >>> --- a/drivers/serial/samsung.c >>> +++ b/drivers/serial/samsung.c >>> @@ -883,10 +883,10 @@ static struct uart_ops s3c24xx_serial_ops = { >>> >>> static struct uart_driver s3c24xx_uart_drv = { >>> .owner = THIS_MODULE, >>> - .dev_name = "s3c2410_serial", >>> + .driver_name = "s3c2410_serial", >>> .nr = CONFIG_SERIAL_SAMSUNG_UARTS, >>> .cons = S3C24XX_SERIAL_CONSOLE, >>> - .driver_name = S3C24XX_SERIAL_NAME, >>> + .dev_name = S3C24XX_SERIAL_NAME, >>> .major = S3C24XX_SERIAL_MAJOR, >>> .minor = S3C24XX_SERIAL_MINOR, >>> }; >>> >>> >>> _______________________________________________ >>> linux-arm-kernel mailing list >>> linux-arm-kernel@lists.infradead.org >>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >> >> > ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RESEND PATCH] serial: samsung: fix device name 2010-09-24 16:37 ` Paulius Zaleckas @ 2010-09-27 0:18 ` Ben Dooks 2010-09-27 8:20 ` Paulius Zaleckas ` (2 more replies) 0 siblings, 3 replies; 13+ messages in thread From: Ben Dooks @ 2010-09-27 0:18 UTC (permalink / raw) To: Paulius Zaleckas Cc: Darius Augulis, kgene.kim, linux-serial, linux-arm-kernel, Ben Dooks, linux-kernel On 24/09/10 17:37, Paulius Zaleckas wrote: > On 09/24/2010 09:57 AM, Darius Augulis wrote: >> Hi, >> >> On Fri, Sep 24, 2010 at 2:40 AM, Ben Dooks<ben-linux@fluff.org> wrote: >>> On 23/09/10 20:15, Darius Augulis wrote: >>>> Swap device and driver names in serial/samsung.c >>> >>> This is far too short, please see the notes below on trying >>> to make this more informative. >>> >>>> Signed-off-by: Darius Augulis<augulis.darius@gmail.com> >>>> --- >>>> >>>> This patch was submitted about 3 months ago, but still not merged. >>>> There was another similar patch from Joonyoung Shim >>>> <jy0922.shim@samsung.com> and was discussed here: >>>> http://marc.info/?l=linux-serial&m=127416101222281&w=2. >>>> Joonyoung Shim acked my patch and other people on ARM mailing list >>>> acked it. The maintainer, Ben Dooks, still not responding for >>>> a long time. Another maintainer, Kukjin Kim, refused to merge >>>> it without Ben's review. >>>> I would like to ask somebody pick up this bugfix. >>> >>> I belive last time this was brought up I asked about the affect >>> this has on the userspace. The following issues would be helpful >>> or essential to have noted in the header about the effect of this. >>> >>> - Does it change the /dev name of the device? if so I would thinl >>> carefully about applying it, as it would be a change in the way >>> that userspace sees the kernel. >> >> It does - now devices are named /dev/s3c2410_serial, and patch changes >> its name to /dev/ttySAC >> >>> >>> - Does it change the kernel output itself? A note on what diffeences >>> can be seen in things like dmesg would be helpful. >> >> It does. Serial driver reports device names when probing, so there >> will appear ttySACx instead of >> s3c2410_serialx. >> >>> >>> - Are there any other side effects >>> >>> - Why is this a bug? Maybe the previous points will explain what is >>> going on, but if not, then a reasonably concise description of >>> what is going on here. >> >> This is bug, because of several points: >> >> 1. Because it contradicts kernel documentation. Please read >> Documentation/arm/Samsung-S3C24XX/Overview.txt line 196. >> This should be enough to apply this patch. >> >> 2. Because s3c2410_serial isn't correct name for serial device node. >> It's name of Samsung serial driver. >> >> 3. Because now almost all userspace systems workaround it by creating >> symlink >> /dev/ttySACx> /dev/s3c2410_serialx and only then put some getty on >> created symlink, not on original device. >> Systems which don't create this symlink, fail to boot at all, because >> of wrong console name. Good example is Buildroot. > > I had similar issue with buildroot too, because in /etc/securetty it is > defained as ttySAC0 > > 4. For console in kernel boot command line you must enter console=ttySACx. > Why it sould be different in userspace? > > For me it seems taht this bug was not noticed earlier, because most > embedded > systems were using static device nodes and ttySACx was used in these cases. As long as these are explained, then I'm reasonably happy for this to be applied, as long as there are no other complaints. However, this is a big change, and I think it should await the next merge window. ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RESEND PATCH] serial: samsung: fix device name 2010-09-27 0:18 ` Ben Dooks @ 2010-09-27 8:20 ` Paulius Zaleckas 2010-09-27 8:24 ` Darius Augulis 2010-10-22 7:02 ` Darius Augulis 2 siblings, 0 replies; 13+ messages in thread From: Paulius Zaleckas @ 2010-09-27 8:20 UTC (permalink / raw) To: Ben Dooks Cc: Darius Augulis, kgene.kim, linux-serial, linux-arm-kernel, linux-kernel On Mon, Sep 27, 2010 at 3:18 AM, Ben Dooks <ben-linux@fluff.org> wrote: > On 24/09/10 17:37, Paulius Zaleckas wrote: >> On 09/24/2010 09:57 AM, Darius Augulis wrote: >>> Hi, >>> >>> On Fri, Sep 24, 2010 at 2:40 AM, Ben Dooks<ben-linux@fluff.org> wrote: >>>> On 23/09/10 20:15, Darius Augulis wrote: >>>>> Swap device and driver names in serial/samsung.c >>>> >>>> This is far too short, please see the notes below on trying >>>> to make this more informative. >>>> >>>>> Signed-off-by: Darius Augulis<augulis.darius@gmail.com> >>>>> --- >>>>> >>>>> This patch was submitted about 3 months ago, but still not merged. >>>>> There was another similar patch from Joonyoung Shim >>>>> <jy0922.shim@samsung.com> and was discussed here: >>>>> http://marc.info/?l=linux-serial&m=127416101222281&w=2. >>>>> Joonyoung Shim acked my patch and other people on ARM mailing list >>>>> acked it. The maintainer, Ben Dooks, still not responding for >>>>> a long time. Another maintainer, Kukjin Kim, refused to merge >>>>> it without Ben's review. >>>>> I would like to ask somebody pick up this bugfix. >>>> >>>> I belive last time this was brought up I asked about the affect >>>> this has on the userspace. The following issues would be helpful >>>> or essential to have noted in the header about the effect of this. >>>> >>>> - Does it change the /dev name of the device? if so I would thinl >>>> carefully about applying it, as it would be a change in the way >>>> that userspace sees the kernel. >>> >>> It does - now devices are named /dev/s3c2410_serial, and patch changes >>> its name to /dev/ttySAC >>> >>>> >>>> - Does it change the kernel output itself? A note on what diffeences >>>> can be seen in things like dmesg would be helpful. >>> >>> It does. Serial driver reports device names when probing, so there >>> will appear ttySACx instead of >>> s3c2410_serialx. >>> >>>> >>>> - Are there any other side effects >>>> >>>> - Why is this a bug? Maybe the previous points will explain what is >>>> going on, but if not, then a reasonably concise description of >>>> what is going on here. >>> >>> This is bug, because of several points: >>> >>> 1. Because it contradicts kernel documentation. Please read >>> Documentation/arm/Samsung-S3C24XX/Overview.txt line 196. >>> This should be enough to apply this patch. >>> >>> 2. Because s3c2410_serial isn't correct name for serial device node. >>> It's name of Samsung serial driver. >>> >>> 3. Because now almost all userspace systems workaround it by creating >>> symlink >>> /dev/ttySACx> /dev/s3c2410_serialx and only then put some getty on >>> created symlink, not on original device. >>> Systems which don't create this symlink, fail to boot at all, because >>> of wrong console name. Good example is Buildroot. >> >> I had similar issue with buildroot too, because in /etc/securetty it is >> defained as ttySAC0 >> >> 4. For console in kernel boot command line you must enter console=ttySACx. >> Why it sould be different in userspace? >> >> For me it seems taht this bug was not noticed earlier, because most >> embedded >> systems were using static device nodes and ttySACx was used in these cases. > > As long as these are explained, then I'm reasonably happy for this to be > applied, as long as there are no other complaints. > > However, this is a big change, and I think it should await the next > merge window. I also agree that it should be applied to next release. -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RESEND PATCH] serial: samsung: fix device name 2010-09-27 0:18 ` Ben Dooks 2010-09-27 8:20 ` Paulius Zaleckas @ 2010-09-27 8:24 ` Darius Augulis 2011-01-12 6:15 ` Kukjin Kim 2010-10-22 7:02 ` Darius Augulis 2 siblings, 1 reply; 13+ messages in thread From: Darius Augulis @ 2010-09-27 8:24 UTC (permalink / raw) To: Ben Dooks Cc: Paulius Zaleckas, kgene.kim, linux-serial, linux-arm-kernel, linux-kernel On Mon, Sep 27, 2010 at 3:18 AM, Ben Dooks <ben-linux@fluff.org> wrote: > On 24/09/10 17:37, Paulius Zaleckas wrote: >> On 09/24/2010 09:57 AM, Darius Augulis wrote: >>> Hi, >>> >>> On Fri, Sep 24, 2010 at 2:40 AM, Ben Dooks<ben-linux@fluff.org> wrote: >>>> On 23/09/10 20:15, Darius Augulis wrote: >>>>> Swap device and driver names in serial/samsung.c >>>> >>>> This is far too short, please see the notes below on trying >>>> to make this more informative. >>>> >>>>> Signed-off-by: Darius Augulis<augulis.darius@gmail.com> >>>>> --- >>>>> >>>>> This patch was submitted about 3 months ago, but still not merged. >>>>> There was another similar patch from Joonyoung Shim >>>>> <jy0922.shim@samsung.com> and was discussed here: >>>>> http://marc.info/?l=linux-serial&m=127416101222281&w=2. >>>>> Joonyoung Shim acked my patch and other people on ARM mailing list >>>>> acked it. The maintainer, Ben Dooks, still not responding for >>>>> a long time. Another maintainer, Kukjin Kim, refused to merge >>>>> it without Ben's review. >>>>> I would like to ask somebody pick up this bugfix. >>>> >>>> I belive last time this was brought up I asked about the affect >>>> this has on the userspace. The following issues would be helpful >>>> or essential to have noted in the header about the effect of this. >>>> >>>> - Does it change the /dev name of the device? if so I would thinl >>>> carefully about applying it, as it would be a change in the way >>>> that userspace sees the kernel. >>> >>> It does - now devices are named /dev/s3c2410_serial, and patch changes >>> its name to /dev/ttySAC >>> >>>> >>>> - Does it change the kernel output itself? A note on what diffeences >>>> can be seen in things like dmesg would be helpful. >>> >>> It does. Serial driver reports device names when probing, so there >>> will appear ttySACx instead of >>> s3c2410_serialx. >>> >>>> >>>> - Are there any other side effects >>>> >>>> - Why is this a bug? Maybe the previous points will explain what is >>>> going on, but if not, then a reasonably concise description of >>>> what is going on here. >>> >>> This is bug, because of several points: >>> >>> 1. Because it contradicts kernel documentation. Please read >>> Documentation/arm/Samsung-S3C24XX/Overview.txt line 196. >>> This should be enough to apply this patch. >>> >>> 2. Because s3c2410_serial isn't correct name for serial device node. >>> It's name of Samsung serial driver. >>> >>> 3. Because now almost all userspace systems workaround it by creating >>> symlink >>> /dev/ttySACx> /dev/s3c2410_serialx and only then put some getty on >>> created symlink, not on original device. >>> Systems which don't create this symlink, fail to boot at all, because >>> of wrong console name. Good example is Buildroot. >> >> I had similar issue with buildroot too, because in /etc/securetty it is >> defained as ttySAC0 >> >> 4. For console in kernel boot command line you must enter console=ttySACx. >> Why it sould be different in userspace? >> >> For me it seems taht this bug was not noticed earlier, because most >> embedded >> systems were using static device nodes and ttySACx was used in these cases. > > As long as these are explained, then I'm reasonably happy for this to be > applied, as long as there are no other complaints. > > However, this is a big change, and I think it should await the next > merge window. I agree that too. > -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: [RESEND PATCH] serial: samsung: fix device name 2010-09-27 8:24 ` Darius Augulis @ 2011-01-12 6:15 ` Kukjin Kim 0 siblings, 0 replies; 13+ messages in thread From: Kukjin Kim @ 2011-01-12 6:15 UTC (permalink / raw) To: 'Darius Augulis', 'Ben Dooks' Cc: 'Paulius Zaleckas', linux-serial, linux-arm-kernel, linux-kernel Darius Augulis wrote: > > On Mon, Sep 27, 2010 at 3:18 AM, Ben Dooks <ben-linux@fluff.org> wrote: > > On 24/09/10 17:37, Paulius Zaleckas wrote: > >> On 09/24/2010 09:57 AM, Darius Augulis wrote: > >>> Hi, > >>> > >>> On Fri, Sep 24, 2010 at 2:40 AM, Ben Dooks<ben-linux@fluff.org> wrote: > >>>> On 23/09/10 20:15, Darius Augulis wrote: > >>>>> Swap device and driver names in serial/samsung.c > >>>> > >>>> This is far too short, please see the notes below on trying > >>>> to make this more informative. > >>>> > >>>>> Signed-off-by: Darius Augulis<augulis.darius@gmail.com> > >>>>> --- > >>>>> > >>>>> This patch was submitted about 3 months ago, but still not merged. > >>>>> There was another similar patch from Joonyoung Shim > >>>>> <jy0922.shim@samsung.com> and was discussed here: > >>>>> http://marc.info/?l=linux-serial&m=127416101222281&w=2. > >>>>> Joonyoung Shim acked my patch and other people on ARM mailing list > >>>>> acked it. The maintainer, Ben Dooks, still not responding for > >>>>> a long time. Another maintainer, Kukjin Kim, refused to merge > >>>>> it without Ben's review. > >>>>> I would like to ask somebody pick up this bugfix. > >>>> > >>>> I belive last time this was brought up I asked about the affect > >>>> this has on the userspace. The following issues would be helpful > >>>> or essential to have noted in the header about the effect of this. > >>>> > >>>> - Does it change the /dev name of the device? if so I would thinl > >>>> carefully about applying it, as it would be a change in the way > >>>> that userspace sees the kernel. > >>> > >>> It does - now devices are named /dev/s3c2410_serial, and patch changes > >>> its name to /dev/ttySAC > >>> > >>>> > >>>> - Does it change the kernel output itself? A note on what diffeences > >>>> can be seen in things like dmesg would be helpful. > >>> > >>> It does. Serial driver reports device names when probing, so there > >>> will appear ttySACx instead of > >>> s3c2410_serialx. > >>> > >>>> > >>>> - Are there any other side effects > >>>> > >>>> - Why is this a bug? Maybe the previous points will explain what is > >>>> going on, but if not, then a reasonably concise description of > >>>> what is going on here. > >>> > >>> This is bug, because of several points: > >>> > >>> 1. Because it contradicts kernel documentation. Please read > >>> Documentation/arm/Samsung-S3C24XX/Overview.txt line 196. > >>> This should be enough to apply this patch. > >>> > >>> 2. Because s3c2410_serial isn't correct name for serial device node. > >>> It's name of Samsung serial driver. > >>> > >>> 3. Because now almost all userspace systems workaround it by creating > >>> symlink > >>> /dev/ttySACx> /dev/s3c2410_serialx and only then put some getty on > >>> created symlink, not on original device. > >>> Systems which don't create this symlink, fail to boot at all, because > >>> of wrong console name. Good example is Buildroot. > >> > >> I had similar issue with buildroot too, because in /etc/securetty it is > >> defained as ttySAC0 > >> > >> 4. For console in kernel boot command line you must enter console=ttySACx. > >> Why it sould be different in userspace? > >> > >> For me it seems taht this bug was not noticed earlier, because most > >> embedded > >> systems were using static device nodes and ttySACx was used in these cases. > > > > As long as these are explained, then I'm reasonably happy for this to be > > applied, as long as there are no other complaints. > > > > However, this is a big change, and I think it should await the next > > merge window. > > I agree that too. > Hi Darius and all, Maybe you remember this, I applied this in my for-next for 38 this merge window. If any opinions, please let me know. Thanks and Happy New year :) Best regards, Kgene. -- Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RESEND PATCH] serial: samsung: fix device name 2010-09-27 0:18 ` Ben Dooks 2010-09-27 8:20 ` Paulius Zaleckas 2010-09-27 8:24 ` Darius Augulis @ 2010-10-22 7:02 ` Darius Augulis 2 siblings, 0 replies; 13+ messages in thread From: Darius Augulis @ 2010-10-22 7:02 UTC (permalink / raw) To: Ben Dooks Cc: Paulius Zaleckas, kgene.kim, linux-serial, linux-arm-kernel, linux-kernel Hi Ben, Kukjin, please don't forget to add this change to your tree for this merge window. Thanks, Darius On Mon, Sep 27, 2010 at 3:18 AM, Ben Dooks <ben-linux@fluff.org> wrote: > On 24/09/10 17:37, Paulius Zaleckas wrote: >> On 09/24/2010 09:57 AM, Darius Augulis wrote: >>> Hi, >>> >>> On Fri, Sep 24, 2010 at 2:40 AM, Ben Dooks<ben-linux@fluff.org> wrote: >>>> On 23/09/10 20:15, Darius Augulis wrote: >>>>> Swap device and driver names in serial/samsung.c >>>> >>>> This is far too short, please see the notes below on trying >>>> to make this more informative. >>>> >>>>> Signed-off-by: Darius Augulis<augulis.darius@gmail.com> >>>>> --- >>>>> >>>>> This patch was submitted about 3 months ago, but still not merged. >>>>> There was another similar patch from Joonyoung Shim >>>>> <jy0922.shim@samsung.com> and was discussed here: >>>>> http://marc.info/?l=linux-serial&m=127416101222281&w=2. >>>>> Joonyoung Shim acked my patch and other people on ARM mailing list >>>>> acked it. The maintainer, Ben Dooks, still not responding for >>>>> a long time. Another maintainer, Kukjin Kim, refused to merge >>>>> it without Ben's review. >>>>> I would like to ask somebody pick up this bugfix. >>>> >>>> I belive last time this was brought up I asked about the affect >>>> this has on the userspace. The following issues would be helpful >>>> or essential to have noted in the header about the effect of this. >>>> >>>> - Does it change the /dev name of the device? if so I would thinl >>>> carefully about applying it, as it would be a change in the way >>>> that userspace sees the kernel. >>> >>> It does - now devices are named /dev/s3c2410_serial, and patch changes >>> its name to /dev/ttySAC >>> >>>> >>>> - Does it change the kernel output itself? A note on what diffeences >>>> can be seen in things like dmesg would be helpful. >>> >>> It does. Serial driver reports device names when probing, so there >>> will appear ttySACx instead of >>> s3c2410_serialx. >>> >>>> >>>> - Are there any other side effects >>>> >>>> - Why is this a bug? Maybe the previous points will explain what is >>>> going on, but if not, then a reasonably concise description of >>>> what is going on here. >>> >>> This is bug, because of several points: >>> >>> 1. Because it contradicts kernel documentation. Please read >>> Documentation/arm/Samsung-S3C24XX/Overview.txt line 196. >>> This should be enough to apply this patch. >>> >>> 2. Because s3c2410_serial isn't correct name for serial device node. >>> It's name of Samsung serial driver. >>> >>> 3. Because now almost all userspace systems workaround it by creating >>> symlink >>> /dev/ttySACx> /dev/s3c2410_serialx and only then put some getty on >>> created symlink, not on original device. >>> Systems which don't create this symlink, fail to boot at all, because >>> of wrong console name. Good example is Buildroot. >> >> I had similar issue with buildroot too, because in /etc/securetty it is >> defained as ttySAC0 >> >> 4. For console in kernel boot command line you must enter console=ttySACx. >> Why it sould be different in userspace? >> >> For me it seems taht this bug was not noticed earlier, because most >> embedded >> systems were using static device nodes and ttySACx was used in these cases. > > As long as these are explained, then I'm reasonably happy for this to be > applied, as long as there are no other complaints. > > However, this is a big change, and I think it should await the next > merge window. > -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2011-01-12 6:15 UTC | newest] Thread overview: 13+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2010-09-23 19:15 [RESEND PATCH] serial: samsung: fix device name Darius Augulis 2010-09-23 19:40 ` Wolfram Sang 2010-09-23 23:40 ` Ben Dooks 2010-09-24 6:57 ` Darius Augulis 2010-09-24 7:34 ` Simon Richter 2010-09-24 7:42 ` Russell King - ARM Linux 2010-09-27 0:17 ` Ben Dooks 2010-09-24 16:37 ` Paulius Zaleckas 2010-09-27 0:18 ` Ben Dooks 2010-09-27 8:20 ` Paulius Zaleckas 2010-09-27 8:24 ` Darius Augulis 2011-01-12 6:15 ` Kukjin Kim 2010-10-22 7:02 ` Darius Augulis
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).