Re: [PATCH resend] Add sc16is7x2 driver

[Manuel Stahl <manuel.stahl@iis.fraunhofer.de>]

[-- Attachment #1: Type: text/plain, Size: 1297 bytes --]

On 14.10.2010 21:01, Greg KH wrote:
> On Thu, Oct 07, 2010 at 10:15:07AM +0200, Manuel Stahl wrote:
>> --- /dev/null
>> +++ b/include/linux/spi/sc16is7x2.h
>> @@ -0,0 +1,17 @@
>> +#ifndef LINUX_SPI_SC16IS752_H
>> +#define LINUX_SPI_SC16IS752_H
>> +
>> +#define SC16IS7X2_NR_GPIOS 8
>> +
>> +struct sc16is7x2_platform_data {
>> +	unsigned int	uartclk;
>> +	/* uart line number of the first channel */
>> +	unsigned	uart_base;
>> +	/* number assigned to the first GPIO */
>> +	unsigned	gpio_base;
>> +	char		*label;
>> +	/* list of GPIO names (array length = SC16IS7X2_NR_GPIOS) */
>> +	const char	*const *names;
>> +};
>> +
>> +#endif
>
> Why is this needed in a .h file?  What other .c file uses this define
> and structure?
>
> thanks,
>
> greg k-h

The board setup code can pass information about the uart and gpio 
enumeration. It can also define names for the GPIOs. Futhermore the base 
clock of the chip must be known, as it can be clocked by an external device.

Regards,
-- 
Manuel Stahl
Fraunhofer-Institut IIS
Leistungsoptimierte Systeme

Nordostpark 93
D90411 Nürnberg
Telefon  +49 (0)911/58061-6419
Fax      +49 (0)911/58061-6398
E-Mail   manuel.stahl@iis.fraunhofer.de

http://www.iis.fraunhofer.de
http://www.smart-power.fraunhofer.de

[-- Attachment #2: manuel_stahl.vcf --]
[-- Type: text/x-vcard, Size: 161 bytes --]

begin:vcard
fn:Manuel Stahl
n:Stahl;Manuel
email;internet:manuel.stahl@iis.fraunhofer.de
tel;work:+49 911 58061-6419
x-mozilla-html:FALSE
version:2.1
end:vcard