linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Williamson <michael.williamson@criticallink.com>
To: linux-serial@vger.kernel.org
Cc: "davinci-linux-open-source@linux.davincidsp.com"
	<davinci-linux-open-source@linux.davincidsp.com>
Subject: Need to disable MSR interrupts in 8250 driver.  Request for guidance...
Date: Mon, 03 Jan 2011 09:15:10 -0500	[thread overview]
Message-ID: <4D21D9EE.7070503@criticallink.com> (raw)

Hello,

I am working on platform from the davinci architecture that uses the 8520 UART
driver.  However, there are some configurations that do not have a valid
CTS input pin (it is a multi-purpose pin on a SoC part, and it may be configured
for other functions).  These configurations can cause a pile of "false" 
MSR interrupts.  If, in 8250.c, I set the UART_BUG_NOMSR flag as part of
the up->bugs information, the problem clears up.

The problem is that there is no way to pass bugs information via platform data.  

The link (below) contains a work-around patch that I had submitted to the davinci
group.  It was suggested that I get guidance from the folks on the davinci-serial
list, and that I should consider figuring out a way to set the UART_BUG_NOMSR 
flag from the platform or initialization data.  The patch submission also has a 
more detailed description of the problem for anyone interested.

https://patchwork.kernel.org/patch/442671/

Should I create a new port type, add a new UPF_ flag in the flags field, figure 
out how to pass bugs information via platform data, or continue along the
work-around path?  

Thanks for any insight.

-Mike


             reply	other threads:[~2011-01-03 14:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-03 14:15 Michael Williamson [this message]
2011-01-03 23:56 ` Need to disable MSR interrupts in 8250 driver. Request for guidance Kevin Hilman
2011-01-04  0:07   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D21D9EE.7070503@criticallink.com \
    --to=michael.williamson@criticallink.com \
    --cc=davinci-linux-open-source@linux.davincidsp.com \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).