linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Stephen Warren <swarren@nvidia.com>
Cc: Alan Cox <alan@linux.intel.com>,
	"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	Dirk Brandewie <dirk.brandewie@gmail.com>,
	"x86@kernel.org" <x86@kernel.org>
Subject: Re: ce4100 does no longer boots with CONFIG_EARLY_PRINTK enabled
Date: Fri, 17 Jun 2011 09:46:39 +0200	[thread overview]
Message-ID: <4DFB065F.3020208@linutronix.de> (raw)
In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF04992C07EB@HQMAIL01.nvidia.com>

Stephen Warren wrote:

  > Just guessing here, but is the solution to add this patch to ToT?:
> 
> diff --git a/drivers/tty/serial/8250.c b/drivers/tty/serial/8250.c
> index b40f7b9..bca2232 100644
> --- a/drivers/tty/serial/8250.c
> +++ b/drivers/tty/serial/8250.c
> @@ -1107,7 +1107,7 @@ static void autoconfig_16550a(struct uart_8250_port *up)
>                          */
>                         DEBUG_AUTOCONF("Xscale ");
>                         up->port.type = PORT_XSCALE;
> -                       up->capabilities |= UART_CAP_UUE;
> +                       up->capabilities |= UART_CAP_UUE | UART_CAP_RTOIE;
>                         return;
>                 }
>         } else {

With that patch I have a working serial again.

> I added a new flag used for both XSCALE and TEGRA port types, and
> modified the XSCALE port type to define the new flag, thinking that all
> code would take the capabilities from that port type table entry, but
> perhaps the auto-detection logic needs an equivalent change for XSCALE.
> 
>> I'm little worried that it seems somehow that I have two uarts at
>> 0xdffe0200 and IRQ4 which is evil.
> 
> That does sound odd. It's very unclear to me how my change would cause
> that...

Seems unrelated to your change.

Sebastian

      reply	other threads:[~2011-06-17  7:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-16 19:11 ce4100 does no longer boots with CONFIG_EARLY_PRINTK enabled Sebastian Andrzej Siewior
2011-06-16 19:23 ` Stephen Warren
2011-06-17  7:46   ` Sebastian Andrzej Siewior [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DFB065F.3020208@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=alan@linux.intel.com \
    --cc=dirk.brandewie@gmail.com \
    --cc=gregkh@suse.de \
    --cc=linux-serial@vger.kernel.org \
    --cc=swarren@nvidia.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).