Linux Serial subsystem development
 help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@gmail.com>
To: linux-serial@vger.kernel.org
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, Greg KH <gregkh@suse.de>,
	linux@arm.linux.org.uk
Subject: [UART] Why CAP_SYS_ADMIN can open non-started port?
Date: Wed, 17 Aug 2011 11:25:27 +0200	[thread overview]
Message-ID: <4E4B8907.8030008@gmail.com> (raw)

Hi,

while I was in the process of uart cleanup, I found this:
static int uart_startup(...) {
  ...
  retval = port->ops->startup(port);
  ...
  if (retval && capable(CAP_SYS_ADMIN))
    retval = 0;

  return retval;
}

Why CAP_SYS_ADMIN should not see the failing port startup? Does anybody
from you remember if it is for some kind of possibility to later
re-autoconfigure the port or something like that?

thanks,
-- 
js

             reply	other threads:[~2011-08-17  9:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-17  9:25 Jiri Slaby [this message]
2011-08-17 10:13 ` [UART] Why CAP_SYS_ADMIN can open non-started port? Alan Cox
2011-08-17 11:48   ` [PATCH] TTY: serial, document ignoring of uart->ops->startup error Jiri Slaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E4B8907.8030008@gmail.com \
    --to=jirislaby@gmail.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=gregkh@suse.de \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox