From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Slaby Subject: Re: [PATCH 1/4] TTY: serial, fix locking imbalance Date: Fri, 23 Sep 2011 21:21:20 +0200 Message-ID: <4E7CDC30.8070607@gmail.com> References: <1314818699-10873-1-git-send-email-jslaby@suse.cz> <20110922224653.GB21296@kroah.com> <4E7CD560.8010706@suse.cz> <20110923190840.GA31009@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-fx0-f46.google.com ([209.85.161.46]:33521 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751426Ab1IWTVY (ORCPT ); Fri, 23 Sep 2011 15:21:24 -0400 In-Reply-To: <20110923190840.GA31009@suse.de> Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: Greg KH Cc: Jiri Slaby , Greg KH , Nobuhiro Iwamatsu , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Stephen Rothwell On 09/23/2011 09:08 PM, Greg KH wrote: > On Fri, Sep 23, 2011 at 08:52:16PM +0200, Jiri Slaby wrote: >> On 09/23/2011 12:46 AM, Greg KH wrote: >>> On Wed, Aug 31, 2011 at 09:24:56PM +0200, Jiri Slaby wrote: >>>> Commit "TTY: serial, move locking in uart_close" moved the lock, but >>>> omitted to update branches which unlock the lock. Now they try to >>>> unlock the lock without holding it. >>>> >>>> Signed-off-by: Jiri Slaby >>>> --- >>>> If possible, please, merge this into the patch mentioned above (it's >>>> not upstream yet). >>> >>> I can't do that, >> >> Hmm, but what is the reason for that? I mean, why do you prefer a kernel >> with broken history with respect to bisection? Per definition -next >> doesn't mind rebases in subtrees. Or is this already in tty-linus branch >> (I cannot check now, obviously)? > > Because it is in my tree and I can't rebase it as others depend on it > (linux-next and others.) linux-next doesn't mind if you rebase. That's exactly what it is for. To test commits collected from #for-next branches and alter them if needed. It merges whatever is in the current branch no matter what was there some days ago. But if there are more trees depending on the tree, then OK, I will live with that ;). thanks, -- js