From: Michal Simek <monstr@monstr.eu>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-serial@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>,
LKML <linux-kernel@vger.kernel.org>,
Peter Korsgaard <jacmet@sunsite.dk>
Subject: Re: Using serial driver 16550A in poll mode without interrupt connected
Date: Thu, 13 Oct 2011 11:56:52 +0200 [thread overview]
Message-ID: <4E96B5E4.1040602@monstr.eu> (raw)
In-Reply-To: <20111012145153.5490b592@lxorguk.ukuu.org.uk>
Alan Cox wrote:
>> Driver is probed with no IRQ (NO_IRQ = -1 on Microblaze)
>> 83e00000.serial: ttyS0 at MMIO 0x83e01003 (irq = -1) is a 16550A
>
> Zero means no IRQ. NO_IRQ is a legacy internal thing for the old IDE code
> so not something other code should be using. Setting the IRQ to -1 is
> bogus and will confuse the rest of the kernel.
It is on my list. There are still some archs (ARM, etc) which still use it.
>
>> Is it possible to use serial driver without IRQ - or blocking IRQ, etc.?
>
> Within limits - it kills your power management and data rates because of
> the continual polling.
Microblaze does nothing with power management and data rates is no problem -
it could exchange some data to check actual status or so.
We just need to make a decision about generating compatible properties for
serial IPs without IRQ. Our BSP which generate dts from Xilinx tools is able
to check if IRQ is connected and based on that do any action - show error/warning/ignore.
If compatible string is not in DTS driver for this IP is not probed.
If you are saying that Linux serial drivers are not prepared for polling because of any reason
we will handle that in BSP.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian
prev parent reply other threads:[~2011-10-13 9:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-12 13:03 Using serial driver 16550A in poll mode without interrupt connected Michal Simek
2011-10-12 13:51 ` Alan Cox
2011-10-12 15:19 ` Ted Ts'o
2011-10-13 10:08 ` Michal Simek
2011-10-13 9:56 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E96B5E4.1040602@monstr.eu \
--to=monstr@monstr.eu \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=gregkh@suse.de \
--cc=jacmet@sunsite.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).