From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH 1/3] ARM: omap_device: handle first time activation of console device Date: Wed, 16 Nov 2011 08:50:44 -0600 Message-ID: <4EC3CDC4.7000108@gmail.com> References: <1321441346-19591-1-git-send-email-rnayak@ti.com> <1321441346-19591-2-git-send-email-rnayak@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-gx0-f174.google.com ([209.85.161.174]:34245 "EHLO mail-gx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752268Ab1KPOus (ORCPT ); Wed, 16 Nov 2011 09:50:48 -0500 In-Reply-To: <1321441346-19591-2-git-send-email-rnayak@ti.com> Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: Rajendra Nayak Cc: linux-serial@vger.kernel.org, linux-omap@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, khilman@ti.com, linaro-dev@lists.linaro.org, tony@atomide.com, govindraj.raja@ti.com, linux-arm-kernel@lists.infradead.org On 11/16/2011 05:02 AM, Rajendra Nayak wrote: > console device on OMAP is never reset or idled by hwmod post > initial setup, early during boot, for obvious reasons not to > break early debug prints thrown on console. > This leaves the console device enabled at boot and the first activation > of it using hwmod needs to be handled in such a way that a disable is > called followed by an enable of the hwmod, the subsequent activations > can then use the default activation technique. > > To handle this add a new binding to identify a hwmod which is used as > the console device. > > This patch is based on the what is done in serial.c for non-DT builds. > > Signed-off-by: Rajendra Nayak > --- > .../devicetree/bindings/arm/omap/omap.txt | 1 + > arch/arm/plat-omap/omap_device.c | 33 +++++++++++++++++++- > 2 files changed, 33 insertions(+), 1 deletions(-) > > diff --git a/Documentation/devicetree/bindings/arm/omap/omap.txt b/Documentation/devicetree/bindings/arm/omap/omap.txt > index dbdab40..46ffd41 100644 > --- a/Documentation/devicetree/bindings/arm/omap/omap.txt > +++ b/Documentation/devicetree/bindings/arm/omap/omap.txt > @@ -21,6 +21,7 @@ Required properties: > Optional properties: > - ti,no_idle_on_suspend: When present, it prevents the PM to idle the module > during suspend. > +- ti,console_hwmod: boolean, identifies the hwmod used as console device > This doesn't seem right. Which console is not a h/w property. Why can't you use aliases like other platforms are doing? Also, it's not clear in the documentation where this (and ti,no_idle_on_suspend) should go in the DT. Both seem like they should be kernel cmdline params. Rob