From: Claudio Scordino <claudio@evidence.eu.com>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Alan Cox <alan@linux.intel.com>,
Juergen Beisert <jbe@pengutronix.de>,
Matthias Fuchs <mfuchs@ma-fu.de>
Subject: Re: [PATCH 0/8] serial: 8250: support hw-based RS485 direction control (finally!)
Date: Thu, 24 Nov 2011 17:05:27 +0100 [thread overview]
Message-ID: <4ECE6B47.90202@evidence.eu.com> (raw)
In-Reply-To: <20111123150312.GH4063@pengutronix.de>
Il 23/11/2011 16:03, Wolfram Sang ha scritto:
> On Wed, Nov 16, 2011 at 05:24:37PM +0100, Wolfram Sang wrote:
>> Some 8250-variants control the direction pin for RS485 in hardware. Linux has
>> RS485 support these days, so update the 8250-driver to adhere to that. There
>> have been attempts for mainlining this before. So, I started with the version
>> from Matthias which got no further comments, a proof-of-concept for the 16V2750
>> from Jürgen, and reworked it to match the current state of RS485 in Linux. Some
>> minor cleanup patches came along the way. Really looking forward to
>> comments/tags, because I think it is really time to get this functionality into
>> mainline once and for all ;)
>
> Ping. Claudio? What do you think?
Hi Wolfram,
sorry for the delay, but I'm very busy these days.
I noticed that some of your patches revert the changes made by the previous patches in the
same series. So I would have preferred having only one patch with the whole changes wrt to
the mainline.
However, I've understood that some of those patches come from a previous submission that you
preferred to not touch. And I can apply the whole series to check what are the actual changes,
so its' fine.
The RS485 part looks right.
I had a superficial look also at the rest of the code, and its seems OK too. But, honestly, I couldn't
find the time to read it carefully.
Best regards,
Claudio
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2011-11-24 16:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-16 16:24 [PATCH 0/8] serial: 8250: support hw-based RS485 direction control (finally!) Wolfram Sang
2011-11-16 16:24 ` [PATCH 1/8] serial: 8250: replace hardcoded 0xbf with #define Wolfram Sang
2011-11-16 16:24 ` [PATCH 2/8] serial: 8250: Add ioctl to enable auto rs485 mode with some Exar UARTs Wolfram Sang
2011-11-17 9:40 ` Claudio Scordino
2011-11-17 10:09 ` Wolfram Sang
2011-11-16 16:24 ` [PATCH 3/8] serial: 8250: save rs485_flags per instance Wolfram Sang
2011-11-16 16:24 ` [PATCH 4/8] serial: 8250: add RX_DURING_TX capability to RS485 mode Wolfram Sang
2011-11-16 16:24 ` [PATCH 5/8] serial: 8250: reject delaying RTS with RS485 Wolfram Sang
2011-11-17 9:43 ` Claudio Scordino
2011-11-17 10:14 ` Wolfram Sang
2011-11-16 16:24 ` [PATCH 6/8] serial: 8250: update rs485 flags with polarity settings Wolfram Sang
2011-11-16 16:24 ` [PATCH 7/8] serial: 8250: add Exar 16V2750 support Wolfram Sang
2011-11-16 16:24 ` [PATCH 8/8] serial: 8250: fix comment about accessing EMSR Wolfram Sang
2011-11-23 15:03 ` [PATCH 0/8] serial: 8250: support hw-based RS485 direction control (finally!) Wolfram Sang
2011-11-24 16:05 ` Claudio Scordino [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ECE6B47.90202@evidence.eu.com \
--to=claudio@evidence.eu.com \
--cc=alan@linux.intel.com \
--cc=jbe@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mfuchs@ma-fu.de \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).