From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Gortmaker Subject: Re: [PATCH] serial: relocate remaining serial drivers from tty/ to tty/serial/ Date: Wed, 4 Jan 2012 17:43:55 -0500 Message-ID: <4F04D62B.50107@windriver.com> References: <1325707287-31038-1-git-send-email-paul.gortmaker@windriver.com> <20120104220158.3300d65b@pyramind.ukuu.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from mail.windriver.com ([147.11.1.11]:61831 "EHLO mail.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757177Ab2ADWoI (ORCPT ); Wed, 4 Jan 2012 17:44:08 -0500 In-Reply-To: <20120104220158.3300d65b@pyramind.ukuu.org.uk> Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: Alan Cox Cc: alan@linux.intel.com, gregkh@suse.de, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org On 12-01-04 05:01 PM, Alan Cox wrote: > On Wed, 4 Jan 2012 15:01:27 -0500 > Paul Gortmaker wrote: > >> The commit ab4382d27412e7e3e7c936e8d50d8888dfac3df8, >> >> "tty: move drivers/serial/ to drivers/tty/serial/" >> >> put most of the serial drivers together in one place, but the ones >> that were hiding in drivers/char didn't get picked up in that change. >> >> They did get moved in commit a6afd9f3e819de4795fcd356e5bfad446e4323f2 >> >> "tty: move a number of tty drivers from drivers/char/ to drivers/tty/" >> >> but there was no distinction of serial vs. non-serial in the above. >> >> Here we take the remaining serial drivers (mostly legacy multiport >> drivers) and put them alongside all the others in tty/serial/ dir. >> >> We can drop SERIAL_NONSTANDARD's dependency on HAS_IOMEM, since the >> encompassing menu block already has that dependency called out. > > NAK > > The tty/serial directory is the stuff using serial_core. I'm not averse > to moving the others down a layer into more appropriate places but its > already too crowded and in need of re-ordering (eg tty/serial/8250/... > might be an improvement) OK, I can do 8250. What do you have in mind for the legacy multiport drivers then, leave them as-in in drivers/tty or another subdir just for them? Thanks, P. >