From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Shimoda, Yoshihiro" Subject: Re: [PATCH 1/7 v2] dmaengine: add a simple dma library Date: Fri, 03 Feb 2012 17:47:48 +0900 Message-ID: <4F2B9F34.60308@renesas.com> References: <1327589784-4287-1-git-send-email-g.liakhovetski@gmx.de> <1327589784-4287-2-git-send-email-g.liakhovetski@gmx.de> <4F22624E.2090201@renesas.com> <4F27CA7D.601@renesas.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-reply-to: Sender: linux-mmc-owner@vger.kernel.org To: Guennadi Liakhovetski Cc: linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org, Vinod Koul , Magnus Damm , linux-mmc@vger.kernel.org, alsa-devel@alsa-project.org, linux-serial@vger.kernel.org, Paul Mundt List-Id: linux-serial@vger.kernel.org Hi Guennadi-san, 2012/02/03 7:19, Guennadi Liakhovetski wrote: [ snip ] >> >> Thank you for your comment. >> >> I investigaed the issue. I found out the renesas_usbhs driver may >> call tx_submit() in the callback() of the dma-simple finally. > > Sorry, in my first reply to this your email I misread the renesas_usbhs > for an issue with your new SUDMAC driver. Since this is not the case and > my patch seems to be causing a regression, I'll look at it. Thank you for the comment. I found out that if the "power_up" is 0 in the sample_tx_submit(), the pm_state will be changed to "PENDING". And then, even if the renesas_usbhs calls dma_async_issue_pending(), the dma-simple driver doesn't call the simple_chan_xfer_ld_queue(). This is because the driver will call the simple_chan_xfer_ld_queue() when the pm_state is "ESTABLISHED" only. So I guess that we have to modify the simple_issue_pending(). Best regards, Yoshihiro Shimoda > Thanks > Guennadi > > --- > Guennadi Liakhovetski, Ph.D. > Freelance Open-Source Software Developer > http://www.open-technology.de/ > -- Yoshihiro Shimoda