From: Sergei Shtylyov <sshtylyov@mvista.com>
To: John Crispin <blogic@openwrt.org>
Cc: Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH 7/9] SERIAL: MIPS: lantiq: convert serial driver to clkdev api
Date: Fri, 17 Feb 2012 20:53:39 +0300 [thread overview]
Message-ID: <4F3E9423.2000502@mvista.com> (raw)
In-Reply-To: <4F3E84B3.1030201@openwrt.org>
Hello.
On 02/17/2012 07:47 PM, John Crispin wrote:
>> The comment doesn't match the essence of patch.
> sorry
>> Why not just clk_get(&pdev->dev, NULL)?
>> WBR, Sergei
> clk_get_sys uses the clkdev lookup table, which is added by this series.
clk_get() does the same, indirectly.
> it makes the clock code consistent throughout the lantiq related files.
> we use clk connections other places, which we cannot reference with
> clk_get that easily
clkdev assumes you don't need to use connection ID if the clock is bound to
be matched by device ID via the lookup table. clk_get() is a common case when
using clkdev, that's why your use of clk_get_sys() stands out as something
unusual. I'll have to have a look at your lookup tables...
> John
WBR, Sergei
prev parent reply other threads:[~2012-02-17 16:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1329474800-20979-1-git-send-email-blogic@openwrt.org>
2012-02-17 10:33 ` [PATCH 7/9] SERIAL: MIPS: lantiq: convert serial driver to clkdev api John Crispin
2012-02-17 17:39 ` Sergei Shtylyov
2012-02-17 16:47 ` John Crispin
2012-02-17 17:53 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F3E9423.2000502@mvista.com \
--to=sshtylyov@mvista.com \
--cc=blogic@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-serial@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).