From mboxrd@z Thu Jan 1 00:00:00 1970 From: Darren Hart Subject: Re: [PATCH 0/4] pch_uart: Cleanups, board quirks, and user uartclk parameter Date: Tue, 21 Feb 2012 22:39:38 -0800 Message-ID: <4F448DAA.6000207@linux.intel.com> References: <4F4462B8.6030607@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com ([134.134.136.20]:5140 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751830Ab2BVGkO (ORCPT ); Wed, 22 Feb 2012 01:40:14 -0500 In-Reply-To: Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: Tomoya MORINAGA Cc: Linux Kernel Mailing List , Feng Tang , Greg Kroah-Hartman , Alan Cox , linux-serial@vger.kernel.org On 02/21/2012 08:26 PM, Tomoya MORINAGA wrote: > 2012年2月22日12:36 Darren Hart : >> This patch series allows for a functional early serial console as well >> as using the UART after boot. It leaves the CM-iTC board alone. So this >> seems to enable all use cases, while forcing 192MHz breaks the FRI2 >> early serial console. I don't see an advantage to that approach other >> than the obviously simpler code (which is nice, but should not trump >> functionality). > > Your quark "Fish River Island II" is OK. > My concern is default uart_clock remains 1.8432 MHz. > Like I said the advantage before, I think this should be 192MHz not 1.8432 MHz. > > Or do you have any reason 1.8432 MHz should be set as PCH_UART default clock. Ah, that's a good point. We can add a patch to this series that sets the default to 192MHz, drops the CM-iTC quirk, and does nothing in pch_phub probe for the FRI2. Would you care to Ack this series and then follow-up with a patch set the default clock to 192MHz? -- Darren Hart Intel Open Source Technology Center Yocto Project - Linux Kernel