From: Darren Hart <dvhart@linux.intel.com>
To: Tomoya MORINAGA <tomoya.rohm@gmail.com>
Cc: Alan Cox <alan@linux.intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Feng Tang <feng.tang@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-serial@vger.kernel.org
Subject: Re: [PATCH 0/4 V2] pch_uart: Cleanups, board quirks, and user uartclk parameter
Date: Wed, 29 Feb 2012 16:47:58 -0800 [thread overview]
Message-ID: <4F4EC73E.40209@linux.intel.com> (raw)
In-Reply-To: <CANKRQnhFVJAUHAg0qTPFJ8L0L_+-_q4ZtfOnV0wSR1Xa6Mn8UQ@mail.gmail.com>
On 02/29/2012 04:38 PM, Tomoya MORINAGA wrote:
> Hi
>
> Darren's patch series, I think OK.
> However, need to proceed next step.
Great, Greg are you happy with these as they are?
>
> As I said before,
> internal clock(USB_48MHz) should be used than external clock(UART_CLK)
> as default setting.
> --Reasons
> - Users don't always use 1.8432MHz as UART_CLK.
> So, In case of using except 1.8432MHz,
> the user needs to change both pch_phub and pch_uart setting (It's
> bother things).
> - High baud rate can't be used more than 115Kbps
>
> I think there is no merit to use UART_CLK.
>
> ---Merit to use 192MHz
> - Users don't have to care both pch_phub and pch_uart clock setting.
> - High baud rate can be supported
I have no objection to this provided the early serial console can work
without additional patches. So the question now is, how do we force the
192MHz clock setting BEFORE the pch_phub code runs?
--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel
next prev parent reply other threads:[~2012-03-01 0:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-29 18:24 [PATCH 0/4 V2] pch_uart: Cleanups, board quirks, and user uartclk parameter Darren Hart
2012-02-29 18:24 ` [PATCH 1/4] pch_uart: Use uartclk instead of base_baud Darren Hart
2012-03-08 18:58 ` Greg Kroah-Hartman
2012-02-29 18:24 ` [PATCH 2/4] pch_uart: Add Fish River Island II uart clock quirks Darren Hart
2012-02-29 18:24 ` [PATCH 3/4] pch_uart: Add user_uartclk parameter Darren Hart
2012-03-08 18:56 ` Greg Kroah-Hartman
2012-03-08 21:10 ` Darren Hart
2012-02-29 18:24 ` [PATCH 4/4] pch_uart: Use existing default_baud in setup_console Darren Hart
2012-03-01 0:38 ` [PATCH 0/4 V2] pch_uart: Cleanups, board quirks, and user uartclk parameter Tomoya MORINAGA
2012-03-01 0:47 ` Darren Hart [this message]
2012-03-01 0:53 ` Greg Kroah-Hartman
2012-03-07 18:32 ` Darren Hart
2012-03-07 18:39 ` Greg Kroah-Hartman
2012-03-01 1:06 ` Tomoya MORINAGA
2012-03-01 1:12 ` Darren Hart
2012-03-01 2:06 ` Tomoya MORINAGA
2012-03-01 2:07 ` Darren Hart
2012-03-01 2:27 ` Tomoya MORINAGA
2012-03-01 2:40 ` Feng Tang
2012-03-01 19:29 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4EC73E.40209@linux.intel.com \
--to=dvhart@linux.intel.com \
--cc=alan@linux.intel.com \
--cc=feng.tang@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=tomoya.rohm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).