From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 177A8C433F5 for ; Tue, 30 Nov 2021 20:04:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240065AbhK3UH1 (ORCPT ); Tue, 30 Nov 2021 15:07:27 -0500 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]:43892 "EHLO smtp-relay-internal-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240043AbhK3UH0 (ORCPT ); Tue, 30 Nov 2021 15:07:26 -0500 Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id E09E83FFEC for ; Tue, 30 Nov 2021 20:04:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1638302645; bh=fw6PzsUlrYkA4VQaJdC32HD2E/40nvvVW3E5iBZZ8sw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=D44YIkTxWqwQifW6mQtA3mvIIotwVBf3/L//41gQAcpFO0gO0e2lLKcdGf80Io0I+ A4tObL84HgkB60VEFTEuN0FEOc6B45mHHW6u4QXVzz6T17kHupyGoFKxLpqtQ4wb4N GLoC9cea1lioI4q/5W53oGwln5Wsba84ZEY1d9rIQVQbBCP+LsylGxvQ60OUO3qKMf 3/6XXSzoFGnidY3yzcza60RSoa2p+xA5OJLE8Yppb/LJjAMeCTS7/WZfnoSpSuqBCm WbaCjjtljH/UWjeZIm0jJfBwVoOd/K8ieR7bc5iUMcHRIMCZsNmJzjYLxcL41u62lu i3sZrPOLkCEBA== Received: by mail-lj1-f200.google.com with SMTP id w16-20020a05651c103000b00218c9d46faeso7937641ljm.2 for ; Tue, 30 Nov 2021 12:04:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=fw6PzsUlrYkA4VQaJdC32HD2E/40nvvVW3E5iBZZ8sw=; b=1g1XlNxucl181QaM2wybCiGaIlpNnqFcc2f1XaZGLmhRy2vpC86pSEkK40JiDBRBH6 GVwtAA8BDQlXMkapbdVE8Xtaa7s4svlibJUzX1HvZgn21miTZoFP4GuEJ85PMUC/aQDc Cu37ro52ESRIBkVYqqu/jKalb8aLu56aI8hsXUuqJKDWzfB9KQID/EqfhInLVO7hU9kG lOsJ0ZGEmH+KGyM3nBz94sVn1rg77fV/CrUsz2regEo/jOMYW8C2/bziMB7W1k74nXJt gnN3YJQQYy8a6L8dKK8ZtGw3NkZ2P/Su3gbbaN+kPiMAkwaoS615UjzdOvDSiQLBXCrz 2whw== X-Gm-Message-State: AOAM530U49NmgVEkoIc1xK+0lRHax4DEaTUfd9eBRJ6moVjTRMlVXc2O 2Tg49EWom1Yjq2HEnAl9dJpgU+elVFam4jN4j34+EOdAfsrQcF+7oy+AJyTTDzFFGJYziVVtZag sA9j7jRtTkorKQma7x6ivy4ucV83iSJ0tyw9AGCvC9Q== X-Received: by 2002:a05:6512:1313:: with SMTP id x19mr1315893lfu.279.1638302642870; Tue, 30 Nov 2021 12:04:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJwFLghjinwu+ez5oEJYvHxibl/oZqNQ9vjDrtAMuAhvpEiBodlkvDGbx0fxE9dNxNZ4Hjs+pg== X-Received: by 2002:a05:6512:1313:: with SMTP id x19mr1315862lfu.279.1638302642618; Tue, 30 Nov 2021 12:04:02 -0800 (PST) Received: from [192.168.3.67] (89-77-68-124.dynamic.chello.pl. [89.77.68.124]) by smtp.gmail.com with ESMTPSA id v17sm1816842lfd.287.2021.11.30.12.04.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Nov 2021 12:04:02 -0800 (PST) Message-ID: <4b5bebb0-ed74-8132-1e6b-cb7cbc21439c@canonical.com> Date: Tue, 30 Nov 2021 21:04:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Subject: Re: [PATCH v2 RESEND 1/5] dt-bindings: soc: samsung: Add Exynos USI bindings Content-Language: en-US To: Rob Herring , Sam Protsenko Cc: Jiri Slaby , linux-samsung-soc@vger.kernel.org, Greg Kroah-Hartman , Chanho Park , linux-serial@vger.kernel.org, Youngmin Nam , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, David Virag , Jaewon Kim , Rob Herring , linux-kernel@vger.kernel.org References: <20211130111325.29328-1-semen.protsenko@linaro.org> <20211130111325.29328-2-semen.protsenko@linaro.org> <1638294184.179325.2713642.nullmailer@robh.at.kernel.org> From: Krzysztof Kozlowski In-Reply-To: <1638294184.179325.2713642.nullmailer@robh.at.kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On 30/11/2021 18:43, Rob Herring wrote: > On Tue, 30 Nov 2021 13:13:21 +0200, Sam Protsenko wrote: >> Add constants for choosing USIv2 configuration mode in device tree. >> Those are further used in USI driver to figure out which value to write >> into SW_CONF register. Also document USIv2 IP-core bindings. >> >> Signed-off-by: Sam Protsenko >> --- >> Changes in v2: >> - Combined dt-bindings doc and dt-bindings header patches >> - Added i2c node to example in bindings doc >> - Added mentioning of shared internal circuits >> - Added USI_V2_NONE value to bindings header >> >> .../bindings/soc/samsung/exynos-usi.yaml | 135 ++++++++++++++++++ >> include/dt-bindings/soc/samsung,exynos-usi.h | 17 +++ >> 2 files changed, 152 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml >> create mode 100644 include/dt-bindings/soc/samsung,exynos-usi.h >> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > Documentation/devicetree/bindings/soc/samsung/exynos-usi.example.dts:35.39-42.15: Warning (unique_unit_address): /example-0/usi@138200c0/serial@13820000: duplicate unit-address (also used in node /example-0/usi@138200c0/i2c@13820000) Rob, The checker complains about two nodes with same unit-address, even though the node name is different. Does it mean that our idea of embedding two children in USI and having enabled only one (used one) is wrong? usi0: usi@138200c0 { // enabled device/child serial@13820000 { status = "okay"; }; // disabled device, keep for reference and for boards which // would like to use it i2c@13820000 { status = "disabled"; }; }; Best regards, Krzysztof