Re: [PATCH v4 1/8] dt-bindings: serial: describe SA8255p

[Praveen Talari <quic_ptalari@quicinc.com>]

Hi Krzysztof

On 5/5/2025 12:01 PM, Krzysztof Kozlowski wrote:
> On Mon, May 05, 2025 at 08:00:32AM GMT, Praveen Talari wrote:
>> Hi Krzysztof
>>
>> On 5/4/2025 10:39 PM, Krzysztof Kozlowski wrote:
>>> On Fri, May 02, 2025 at 10:44:10PM GMT, Praveen Talari wrote:
>>>> +required:
>>>> +  - compatible
>>>> +  - reg
>>>> +  - interrupts
>>>> +  - power-domains
>>>> +  - power-domain-names
>>>> +
>>>> +unevaluatedProperties: false
>>>> +
>>>> +examples:
>>>> +  - |
>>>> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
>>>> +
>>>> +    serial@990000 {
>>>> +        compatible = "qcom,sa8255p-geni-uart";
>>>> +        reg = <0x990000 0x4000>;
>>>> +        interrupts = <GIC_SPI 531 IRQ_TYPE_LEVEL_HIGH>;
>>> Why isn't here wakeup interrupt? Commit msg also does not help me to
>>> understand why number of interrupts varies.
>> Currently we are not using wake-irq because it is optional for our current
>> implementation.
> Great explanation. I asked why is it optional, answer because it is
> optional.
sorry.
>
> What does it mean optional? This is part of the SoC, so how given one,
> fixed SoC can have it routed or not routed in the same time?

the serial driver doesn't enter runtime suspend mode until the port is 
closed.

therefore, there is no need for a wake IRQ when the driver is in an 
active state


Thanks,

Praveen Talari

>
> Best regards,
> Krzysztof
>