From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: "Martin Hundebøll" <martin@geanix.com>
Cc: linux-serial <linux-serial@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v2 1/3] serial: 8250: allow use of non-runtime configured uart ports
Date: Thu, 20 Oct 2022 17:14:52 +0300 (EEST) [thread overview]
Message-ID: <4ecaa152-3fdc-be46-61a3-b026f4b36a61@linux.intel.com> (raw)
In-Reply-To: <0B4E8D8F-8E89-4951-9B5C-AFDF6667A1CC@geanix.com>
[-- Attachment #1: Type: text/plain, Size: 1272 bytes --]
On Thu, 20 Oct 2022, Martin Hundebøll wrote:
>
>
> On October 20, 2022 2:34:14 PM GMT+02:00, "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com> wrote:
> >On Tue, 18 Oct 2022, Martin Hundebøll wrote:
> >
> >> The logic to find unused ports when registering new 8250 uart ports
> >> searches only up to CONFIG_SERIAL_8250_RUNTIME_UART, which forces users
> >> of external 8250 ports to increase the number of runtime ports
> >> artificially.
> >>
> >> Fix this by initializing each allocated port structure with basic
> >> settings like line number and uart operation callbacks, and by searching
> >> the entire array of allocated ports to find an unused one.
> >
> >So nr_uarts no longer means "Maximum number of UARTs supported." ?
> >Perhaps it should be reworded too.
> >
>
> It never did. Confusingly, the module parameter name (nr_uarts)
> corresponds to CONFIG_SERIAL_8250_RUNTIME_UARTS, and controls the number
> of built-in (non-discoverable) ports. The other config,
> CONFIG_SERIAL_8250_NR_UARTS, controls the maximum number of ports.
>
> We cannot change the module parameter name, so I'm not sure if we should
> map it to another static variable in the source?
I meant that its description should be changed to match what it really
does.
--
i.
next prev parent reply other threads:[~2022-10-20 14:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 13:34 [PATCH v2 1/3] serial: 8250: allow use of non-runtime configured uart ports Martin Hundebøll
2022-10-18 13:34 ` [PATCH v2 2/3] serial: 8250: allow zero runtime-configured ports Martin Hundebøll
2022-10-18 13:34 ` [PATCH v2 3/3] serial: 8250: skip platform device registration with no runtime ports Martin Hundebøll
2022-10-20 13:00 ` Ilpo Järvinen
2022-10-20 12:34 ` [PATCH v2 1/3] serial: 8250: allow use of non-runtime configured uart ports Ilpo Järvinen
2022-10-20 14:10 ` Martin Hundebøll
2022-10-20 14:14 ` Ilpo Järvinen [this message]
2022-10-20 18:34 ` Martin Hundebøll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ecaa152-3fdc-be46-61a3-b026f4b36a61@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-serial@vger.kernel.org \
--cc=martin@geanix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox