Re: [PATCH] Remove BUG_ON from n_tty_read()

[Stanislav Kozina <skozina@redhat.com>]

> Subject should include "tty:" prefix.

Sorry, just forgot about it for the second time;-/
Can I force git format-patch to add it somehow?

> This usually is done in two lines:
>
> if (WARN_ON())
> 	return;

Thanks, good point, new patch sent.

> Additionally, second BUG_ON(!tty->read_buf) in n_tty_read() should be
> probably replaced too.

I don't think so.
In the first case, we are not running, so there might be no operation on 
tty running. We still don't understand how it can happen that someone 
closes the tty, and then read operation is called, however at least 
there is no (known) running operation.
In the other case, we have just be rescheduled - so we are definitely in 
operation, and if tty is closed while we are just sleeping, I would 
still keep BUG_ON() there. Despite we haven't seen any panics on that 
place, have we?

Thanks,
-Stanislav