From: Jiri Slaby <jslaby@suse.cz>
To: Joe Millenbach <jmillenbach@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Cox <alan@linux.intel.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Josh Triplett <josh@joshtriplett.org>,
team-fjord@googlegroups.com, Jiri Slaby <jirislaby@gmail.com>
Subject: Re: [PATCHv2] tty: Added a CONFIG_TTY option to allow removal of TTY
Date: Mon, 03 Sep 2012 23:45:44 +0200 [thread overview]
Message-ID: <50452508.80008@suse.cz> (raw)
In-Reply-To: <CADwDc1DXb3o0i-7NGZKFGwKU6Ybj703OHhUWgh0he9TcCFpW4g@mail.gmail.com>
On 09/03/2012 11:24 PM, Joe Millenbach wrote:
> I do not have a Power PC system to test on
Neither do I. But that is no excuse to break it. There are
cross-compilers for instance.
> so during my testing I did
> not notice that option would need TTY also. Thanks for pointing that
> out. Before I spin a new patch is there anything else I should add?
> I do not know of a way for me to easily test all the different CPU
> specific configurations on my x86 based machines.
Basically everything that does alloc_tty_driver...
You should minimize the risk of breaking !TTY builds (randconfig for
example) on other arches as much as possible. I'm not trying to force
you to do allmodconfig minus TTY on all arches, but at least do 'git
grep' thoroughly.
thanks,
--
js
suse labs
next prev parent reply other threads:[~2012-09-03 21:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-03 0:44 [PATCHv2] tty: Added a CONFIG_TTY option to allow removal of TTY Joe Millenbach
2012-09-03 21:15 ` Jiri Slaby
2012-09-03 21:24 ` Joe Millenbach
2012-09-03 21:45 ` Jiri Slaby [this message]
2012-09-03 21:55 ` Joe Millenbach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50452508.80008@suse.cz \
--to=jslaby@suse.cz \
--cc=alan@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@gmail.com \
--cc=jmillenbach@gmail.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=team-fjord@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox