From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH 08/11] ARM: Move some macros from entry-armv to entry-header Date: Wed, 26 Sep 2012 15:05:24 -0700 Message-ID: <50637C24.90206@codeaurora.org> References: <20120924212648.GA27605@lizard> <1348522080-32629-8-git-send-email-anton.vorontsov@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:1854 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751532Ab2IZWFf (ORCPT ); Wed, 26 Sep 2012 18:05:35 -0400 In-Reply-To: <1348522080-32629-8-git-send-email-anton.vorontsov@linaro.org> Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: Anton Vorontsov Cc: Greg Kroah-Hartman , Russell King , linaro-kernel@lists.linaro.org, patches@linaro.org, Brian Swetland , Jason Wessel , linux-kernel@vger.kernel.org, =?ISO-8859-1?Q?Arve_Hj=F8nnev=E5g?= , John Stultz , linux-serial@vger.kernel.org, Colin Cross , kgdb-bugreport@lists.sourceforge.net, kernel-team@android.com, linux-arm-kernel@lists.infradead.org, Alan Cox On 09/24/12 14:27, Anton Vorontsov wrote: > Just move the macros into header file as we would want to use them for > KGDB FIQ entry code. > > The following macros were moved: > > - svc_entry > - usr_entry > - kuser_cmpxchg_check > - vector_stub > > To make kuser_cmpxchg_check actually work across different files, we > also have to make kuser_cmpxchg64_fixup global. > > Signed-off-by: Anton Vorontsov Why can't we put the fiq entry code from the next patch into entry-armv.S? Sorry if this has been asked before but I don't see any reasoning in the commit text. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation