From: Jiri Slaby <jslaby@suse.cz>
To: Jingoo Han <jg1.han@samsung.com>,
'Greg Kroah-Hartman' <gregkh@linuxfoundation.org>
Cc: linux-serial@vger.kernel.org, 'Chen Jun' <jun.d.chen@intel.com>
Subject: Re: [PATCH] serial: ifx6x60: add missing variable initialization
Date: Wed, 27 Feb 2013 10:53:09 +0100 [thread overview]
Message-ID: <512DD785.5050001@suse.cz> (raw)
In-Reply-To: <008e01ce14a7$c1406580$43c13080$%han@samsung.com>
On 02/27/2013 06:03 AM, Jingoo Han wrote:
> Fixed build warning as below:
>
> drivers/tty/serial/ifx6x60.c:753:8: warning: 'more' may be used uninitialized in this function [-Wuninitialized]
This needs some more investigation and explanation than that. Are you
fixing a real compiler warning or hiding a bug here?
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/tty/serial/ifx6x60.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/tty/serial/ifx6x60.c b/drivers/tty/serial/ifx6x60.c
> index 68d7ce9..3d78baf 100644
> --- a/drivers/tty/serial/ifx6x60.c
> +++ b/drivers/tty/serial/ifx6x60.c
> @@ -687,7 +687,7 @@ static void ifx_spi_complete(void *ctx)
> struct tty_ldisc *ldisc = NULL;
> int length;
> int actual_length;
> - unsigned char more;
> + unsigned char more = 0;
> unsigned char cts;
> int local_write_pending = 0;
> int queue_length;
>
--
js
suse labs
next prev parent reply other threads:[~2013-02-27 9:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-27 5:03 [PATCH] serial: ifx6x60: add missing variable initialization Jingoo Han
2013-02-27 9:53 ` Jiri Slaby [this message]
2013-02-27 10:20 ` Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512DD785.5050001@suse.cz \
--to=jslaby@suse.cz \
--cc=gregkh@linuxfoundation.org \
--cc=jg1.han@samsung.com \
--cc=jun.d.chen@intel.com \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox