From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Slaby Subject: Re: 8250.nr_uarts broken in 3.7 Date: Fri, 08 Mar 2013 23:58:39 +0100 Message-ID: <513A6D1F.5000202@suse.cz> References: <20130307185642.GF13719@hansolo.jdub.homelinux.org> <5138E56B.6090308@suse.cz> <20130307191005.GH13719@hansolo.jdub.homelinux.org> <20130307211426.GI13719@hansolo.jdub.homelinux.org> <20130307231242.GC4280@kroah.com> <20130308010140.GJ13719@hansolo.jdub.homelinux.org> <20130308013923.GA12474@kroah.com> <20130308212722.GL13719@hansolo.jdub.homelinux.org> <513A6A65.9050706@suse.cz> <20130308224950.GM13719@hansolo.jdub.homelinux.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f178.google.com ([209.85.215.178]:64215 "EHLO mail-ea0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757750Ab3CHW6n (ORCPT ); Fri, 8 Mar 2013 17:58:43 -0500 In-Reply-To: <20130308224950.GM13719@hansolo.jdub.homelinux.org> Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: Josh Boyer Cc: Greg Kroah-Hartman , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org On 03/08/2013 11:49 PM, Josh Boyer wrote: > On Fri, Mar 08, 2013 at 11:47:01PM +0100, Jiri Slaby wrote: >> Yeah, I agree this is ugly. Just re-definining MODULE_PARAM_PREFIX at >> the end of the file should do the trick (followed by >> "module_param(nr_uarts, uint, 0644)"). > > For some reason, I thought I had tried that. Maybe I didn't. I'll look > into it again. I see. Because we would re-define some global variables. What if we put module_param into a function? -- js suse labs