Re: [PATCH V3 3/4] ARM64 LPC: support serial based on low-pin-count

Arnd Bergmann
2016-09-14T21:33:56Z

On Wednesday, September 14, 2016 11:04:33 PM CEST zhichang.yuan wrote:
> The 8250_hisi_lpc.c support both ACPI and dts similar to 8250_dw :
>
> +static struct platform_driver hs_lpc8250_driver = {
> + .driver = {
> + .name = "hisi-lpc-uart",
> + .of_match_table = hs8250_of_match,
> + .acpi_match_table = ACPI_PTR(hs8250_acpi_match),
>
> So, I am a little confused why we need to support dts in 8250_of.c and support ACPI in another
> driver file.
>

After looking again, I'm pretty sure that drivers/tty/serial/8250/8250_pnp.c
will handle the ACPI case without modifications, you just need to adapt
the 8250_of driver to handle IORESOURCE_IO ports. This will be required
anyway with the next version once the LPC bridge is on the PCI bus.

Arnd