* [PATCH 1/2] driver: serial-omap: move max uart count into generic header file.
@ 2013-03-18 10:56 Sourav Poddar
2013-03-18 18:45 ` Kevin Hilman
0 siblings, 1 reply; 3+ messages in thread
From: Sourav Poddar @ 2013-03-18 10:56 UTC (permalink / raw)
To: gregkh, tony, rmk+kernel, linux-arm-kernel
Cc: linux-serial, linux-kernel, linux-omap, b-cousson, Sourav Poddar,
Santosh Shilimkar, Felipe Balbi, Rajendra nayak
OMAP_MAX_HSUART_PORTS is moved to omap_serial header file.
Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: Felipe Balbi <balbi@ti.com>
Cc: Rajendra nayak <rnayak@ti.com>
Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
---
drivers/tty/serial/omap-serial.c | 2 --
include/linux/platform_data/serial-omap.h | 1 +
2 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
index 5722eaf..4c2ba9f 100644
--- a/drivers/tty/serial/omap-serial.c
+++ b/drivers/tty/serial/omap-serial.c
@@ -43,8 +43,6 @@
#include <linux/pinctrl/consumer.h>
#include <linux/platform_data/serial-omap.h>
-#define OMAP_MAX_HSUART_PORTS 6
-
#define UART_BUILD_REVISION(x, y) (((x) << 8) | (y))
#define OMAP_UART_REV_42 0x0402
diff --git a/include/linux/platform_data/serial-omap.h b/include/linux/platform_data/serial-omap.h
index ff9b0aa..92c48c2 100644
--- a/include/linux/platform_data/serial-omap.h
+++ b/include/linux/platform_data/serial-omap.h
@@ -29,6 +29,7 @@
* is used as console uart.
*/
#define OMAP_SERIAL_NAME "ttyO"
+#define OMAP_MAX_HSUART_PORTS 6
struct omap_uart_port_info {
bool dma_enabled; /* To specify DMA Mode */
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] driver: serial-omap: move max uart count into generic header file.
2013-03-18 10:56 [PATCH 1/2] driver: serial-omap: move max uart count into generic header file Sourav Poddar
@ 2013-03-18 18:45 ` Kevin Hilman
2013-03-19 6:00 ` Sourav Poddar
0 siblings, 1 reply; 3+ messages in thread
From: Kevin Hilman @ 2013-03-18 18:45 UTC (permalink / raw)
To: Sourav Poddar
Cc: gregkh, tony, rmk+kernel, linux-arm-kernel, linux-serial,
linux-kernel, linux-omap, b-cousson, Santosh Shilimkar,
Felipe Balbi, Rajendra nayak
Sourav Poddar <sourav.poddar@ti.com> writes:
> OMAP_MAX_HSUART_PORTS is moved to omap_serial header file.
Why?
You started to explain it in the cover letter, but a full description
belongs here for the permanent git history.
Kevin
> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
> Cc: Felipe Balbi <balbi@ti.com>
> Cc: Rajendra nayak <rnayak@ti.com>
> Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
> ---
> drivers/tty/serial/omap-serial.c | 2 --
> include/linux/platform_data/serial-omap.h | 1 +
> 2 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
> index 5722eaf..4c2ba9f 100644
> --- a/drivers/tty/serial/omap-serial.c
> +++ b/drivers/tty/serial/omap-serial.c
> @@ -43,8 +43,6 @@
> #include <linux/pinctrl/consumer.h>
> #include <linux/platform_data/serial-omap.h>
>
> -#define OMAP_MAX_HSUART_PORTS 6
> -
> #define UART_BUILD_REVISION(x, y) (((x) << 8) | (y))
>
> #define OMAP_UART_REV_42 0x0402
> diff --git a/include/linux/platform_data/serial-omap.h b/include/linux/platform_data/serial-omap.h
> index ff9b0aa..92c48c2 100644
> --- a/include/linux/platform_data/serial-omap.h
> +++ b/include/linux/platform_data/serial-omap.h
> @@ -29,6 +29,7 @@
> * is used as console uart.
> */
> #define OMAP_SERIAL_NAME "ttyO"
> +#define OMAP_MAX_HSUART_PORTS 6
>
> struct omap_uart_port_info {
> bool dma_enabled; /* To specify DMA Mode */
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] driver: serial-omap: move max uart count into generic header file.
2013-03-18 18:45 ` Kevin Hilman
@ 2013-03-19 6:00 ` Sourav Poddar
0 siblings, 0 replies; 3+ messages in thread
From: Sourav Poddar @ 2013-03-19 6:00 UTC (permalink / raw)
To: Kevin Hilman
Cc: gregkh, tony, rmk+kernel, linux-arm-kernel, linux-serial,
linux-kernel, linux-omap, b-cousson, Santosh Shilimkar,
Felipe Balbi, Rajendra nayak
Hi Kevin,
On Tuesday 19 March 2013 12:15 AM, Kevin Hilman wrote:
> Sourav Poddar<sourav.poddar@ti.com> writes:
>
>> OMAP_MAX_HSUART_PORTS is moved to omap_serial header file.
> Why?
>
The patch is a prerequisitive for the next patch in the series, where I am
making use of the max number of uarts, omap device supports. Hence, I
am rearranging the macro from a driver file to a header file. So, it can
be used at
multiple places.
> You started to explain it in the cover letter, but a full description
> belongs here for the permanent git history.
>
Sure, I will add the complete description for this here itself in my next
version.
> Kevin
>
>> Cc: Santosh Shilimkar<santosh.shilimkar@ti.com>
>> Cc: Felipe Balbi<balbi@ti.com>
>> Cc: Rajendra nayak<rnayak@ti.com>
>> Signed-off-by: Sourav Poddar<sourav.poddar@ti.com>
>> ---
>> drivers/tty/serial/omap-serial.c | 2 --
>> include/linux/platform_data/serial-omap.h | 1 +
>> 2 files changed, 1 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
>> index 5722eaf..4c2ba9f 100644
>> --- a/drivers/tty/serial/omap-serial.c
>> +++ b/drivers/tty/serial/omap-serial.c
>> @@ -43,8 +43,6 @@
>> #include<linux/pinctrl/consumer.h>
>> #include<linux/platform_data/serial-omap.h>
>>
>> -#define OMAP_MAX_HSUART_PORTS 6
>> -
>> #define UART_BUILD_REVISION(x, y) (((x)<< 8) | (y))
>>
>> #define OMAP_UART_REV_42 0x0402
>> diff --git a/include/linux/platform_data/serial-omap.h b/include/linux/platform_data/serial-omap.h
>> index ff9b0aa..92c48c2 100644
>> --- a/include/linux/platform_data/serial-omap.h
>> +++ b/include/linux/platform_data/serial-omap.h
>> @@ -29,6 +29,7 @@
>> * is used as console uart.
>> */
>> #define OMAP_SERIAL_NAME "ttyO"
>> +#define OMAP_MAX_HSUART_PORTS 6
>>
>> struct omap_uart_port_info {
>> bool dma_enabled; /* To specify DMA Mode */
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-19 6:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-18 10:56 [PATCH 1/2] driver: serial-omap: move max uart count into generic header file Sourav Poddar
2013-03-18 18:45 ` Kevin Hilman
2013-03-19 6:00 ` Sourav Poddar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).