From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sourav Poddar Subject: Re: [PATCHv3] driver: serial: prevent UART console idle on suspend while using "no_console_suspend" Date: Wed, 10 Apr 2013 10:57:09 +0530 Message-ID: <5164F82D.3090501@ti.com> References: <1365167733-28083-1-git-send-email-sourav.poddar@ti.com> <20130408171432.GY30923@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130408171432.GY30923@n2100.arm.linux.org.uk> Sender: linux-kernel-owner@vger.kernel.org To: Russell King - ARM Linux Cc: gregkh@linuxfoundation.org, tony@atomide.com, khilman@linaro.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Santosh Shilimkar , Felipe Balbi , Rajendra nayak List-Id: linux-serial@vger.kernel.org Hi Russell, On Monday 08 April 2013 10:44 PM, Russell King - ARM Linux wrote: > On Fri, Apr 05, 2013 at 06:45:33PM +0530, Sourav Poddar wrote: >> With dt boot, uart wakeup after suspend is non functional while using >> "no_console_suspend" in the bootargs. With "no_console_suspend" used, we >> should prevent the runtime suspend of the uart port which is getting used >> as an console. >> >> Cc: Santosh Shilimkar >> Cc: Felipe Balbi >> Cc: Rajendra nayak >> Tested on omap5430evm, omap4430sdp. >> >> Signed-off-by: Sourav Poddar >> --- >> v2->v3 >> Based on Kevin Hilman and Santosh Shilimkar comments, modified >> serial core/driver layer to bypass runtime suspend >> for console uart while using "no_console_suspend". >> >> This patch is based on Santosh Shilimkar serial patch[1] > Rather than introducing this "port_is_console" thing, please move > uart_console() into the serial_core.h header file, making it an inline > function, and use that in omap-serial.c. > > Remember to fix drivers/tty/serial/mpc52xx_uart.c as well for that change. Thanks for the pointer. Will take care of your suggestions in the next version. ~Sourav