From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Hounschell Subject: Re: Out of tree GPL serial tty driver help? Date: Fri, 26 Apr 2013 11:10:14 -0400 Message-ID: <517A98D6.2020701@compro.net> References: <51781A19.5030707@compro.net> <1366926071.3452.17.camel@thor.lan> <517A79E1.8060504@compro.net> <1366983913.3452.33.camel@thor.lan> <517A8EF1.8040006@compro.net> <20130426143526.GA15132@kroah.com> Reply-To: markh@compro.net Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.compro.net ([12.186.155.4]:7078 "EHLO mx2.compro.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750936Ab3DZPKP (ORCPT ); Fri, 26 Apr 2013 11:10:15 -0400 In-Reply-To: <20130426143526.GA15132@kroah.com> Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: Greg KH Cc: Peter Hurley , linux-serial@vger.kernel.org, Mark Hounschell On 04/26/2013 10:35 AM, Greg KH wrote: > On Fri, Apr 26, 2013 at 10:28:01AM -0400, Mark Hounschell wrote: >> This particular driver and one other are normal PCI based cards. I >> also have one other that is PCI-e. This particular one is the only >> one that creates all these weird device entries. The other 2 are >> pretty straight forward. One entry per port. I figured I'd tackle >> this one first. > > I would remove those other "weird" device entries from the driver, we > removed those types of device nodes from the kernel tree many many years > ago. Just stick to one device node per port, and all should be fine. > Ya, you are certainly right there. First things first though. > Also, any reason why these drivers aren't in the main kernel tree? If > they were, all of this work would have been done for you :) > Yes, I wish they were in the kernel. I've had to maintain them since the 2.6 days because Digi just won't do it and their cards do what we need quite well and are still current products. Ya, you can buy a brand new one but the latest kernel supported is 2.6. I think Digi at one point long ago may have tried the "in kernel" route but you probably know more about that than I do. Since 2.6, the maintenance on these hasn't been to bad, until udev came along. But I guess after 3.4 the tty layer is going through quite some changes that I have yet to understand. Actually, we also have 3-4 of our own "out of kernel" GPL drivers that I would love to see in the kernel. They are mature and only require changes when something in the kernel changes. That's another story though. Regards Mark