Re: [RFC 1/8] serial:st-asc: Add ST ASC driver.

[Stuart MENEFY <stuart.menefy@st.com>]

On 10/05/13 16:23, Greg KH wrote:
> On Fri, May 10, 2013 at 04:45:15PM +0200, Ben Dooks wrote:
>> On 08/05/13 17:34, Greg KH wrote:
>>> On Wed, May 08, 2013 at 04:34:43PM +0200, Arnd Bergmann wrote:
>>>>> +#define ASC_MAJOR		204
>>>>> +#define ASC_MINOR_START		40
>>>>
>>>> I don't know what the current policy is on allocating major/minor numbers,
>>>> but I'm sure you cannot just reuse one that is already used.
>>>
>>> I agree, why are you trying to create a new tty device name?  Can't you
>>> use the existing ttyS name and minor number as you will not have any
>>> other type of serial device on this system?
>>
>> This would be an issue on systems that either accept plug-in cards
>> such as PCMCIA/CardBus/PCI or have additional off SoC IO spaces
>> where 8250 compatible UARTS could live.
> 
> I thought these were set-top box systems that couldn't accept any
> plug-in cards or anything else?  This is a SoC, right?

Correct, it is a SoC intended for set-top-box systems. But they are also
expandable and have a PCIe root complex. In the final system this would
normally be used for things like WiFi, but in development boards these
are brought out to generic PCIe slots where pretty much anything can be
plugged in.

We've also had systems in the dim and distant past which used memory
mapped external super I/O controllers which had 8250 compatible serial
ports.

So while its not usual, we have had systems with both ASC and 8250
compatible serial ports, which is why we'd like to keep the option open.

Stuart