From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC1B81FDE31; Wed, 14 May 2025 05:57:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747202278; cv=none; b=Q+BuXUNmc8MtYbxjXVNzK7iUCSRWVevrZM+k5k3WIWjjNTcmFcuZ21PQZOxq76cMnA8OVxoWYgia7QCU3vFiMwbgC8J8RSNZZvdYDRMZdAYsYLWbviBRhAyLzjeBraXJEQCARn79sYDfl1vDGYev5BkyINK8mQIgjcjzrSHDjbg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747202278; c=relaxed/simple; bh=Via0WbJSOQi5O3nYN12ZpM2528gmRa1eiQC3UECK9jI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=i8LOxMMfycDVUf3hwyisJP3JZ8sQgRUH3JOmbpYe7lEujrRd41qWRTt1Pn2Ldt+/j9zwHYs8WqUV5qOXOx2YuXgxXjZUFD7n0bkk3R63vL4dTOHi6NMqDUpw40IsAbsSFQ5/lI0ucVhxiyfoGHWccDQVA/Fd18UMUZIKD8f2T2k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fxYNo2qB; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fxYNo2qB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53F2EC4CEF2; Wed, 14 May 2025 05:57:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747202277; bh=Via0WbJSOQi5O3nYN12ZpM2528gmRa1eiQC3UECK9jI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=fxYNo2qBMKwejd20yBECNUbHLDy7pkr8bpniol+L1FvE3QX9lkod04FL0w53m9ICP Qie5eKk1JEj3cWri+ySNDUVcNP90VpqRYwRKDlpBbKyGvszx9eae3SZHaw/roKPp6h 8HSBl19amP+/ZGILTDaYIzMx/EhXQWYuBqjm1iF6tlHOPGXYj0y+pJtiNasnDwdjZN Jc80DdwzCTAd4q3vuzJUn0va5beDe9F/Jen2tYRLL4lzwHFAxa7Biq8KshLJQiaRfT 1vlntZJycuFEwfUnvQGl7xww8Er4FbWepKA10ujiZk3Igp6npL3WE/Aa1UtUbwLhpf a2hD6t57OXIow== Message-ID: <518b6620-bca0-45e4-8c1f-6cd9ab18bee2@kernel.org> Date: Wed, 14 May 2025 07:57:54 +0200 Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] vt: add TIOCL_GETCURSORPOS to retrieve the screen cursor position To: Nicolas Pitre , Greg Kroah-Hartman Cc: Nicolas Pitre , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250514015554.19978-1-nico@fluxnic.net> <20250514015554.19978-3-nico@fluxnic.net> Content-Language: en-US From: Jiri Slaby Autocrypt: addr=jirislaby@kernel.org; keydata= xsFNBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABzSFKaXJpIFNsYWJ5 IDxqaXJpc2xhYnlAa2VybmVsLm9yZz7CwXcEEwEIACEFAlW3RUwCGwMFCwkIBwIGFQgJCgsC BBYCAwECHgECF4AACgkQvSWxBAa0cEnVTg//TQpdIAr8Tn0VAeUjdVIH9XCFw+cPSU+zMSCH eCZoA/N6gitEcnvHoFVVM7b3hK2HgoFUNbmYC0RdcSc80pOF5gCnACSP9XWHGWzeKCARRcQR 4s5YD8I4VV5hqXcKo2DFAtIOVbHDW+0okOzcecdasCakUTr7s2fXz97uuoc2gIBB7bmHUGAH XQXHvdnCLjDjR+eJN+zrtbqZKYSfj89s/ZHn5Slug6w8qOPT1sVNGG+eWPlc5s7XYhT9z66E l5C0rG35JE4PhC+tl7BaE5IwjJlBMHf/cMJxNHAYoQ1hWQCKOfMDQ6bsEr++kGUCbHkrEFwD UVA72iLnnnlZCMevwE4hc0zVhseWhPc/KMYObU1sDGqaCesRLkE3tiE7X2cikmj/qH0CoMWe gjnwnQ2qVJcaPSzJ4QITvchEQ+tbuVAyvn9H+9MkdT7b7b2OaqYsUP8rn/2k1Td5zknUz7iF oJ0Z9wPTl6tDfF8phaMIPISYrhceVOIoL+rWfaikhBulZTIT5ihieY9nQOw6vhOfWkYvv0Dl o4GRnb2ybPQpfEs7WtetOsUgiUbfljTgILFw3CsPW8JESOGQc0Pv8ieznIighqPPFz9g+zSu Ss/rpcsqag5n9rQp/H3WW5zKUpeYcKGaPDp/vSUovMcjp8USIhzBBrmI7UWAtuedG9prjqfO wU0ETpLnhgEQAM+cDWLL+Wvc9cLhA2OXZ/gMmu7NbYKjfth1UyOuBd5emIO+d4RfFM02XFTI t4MxwhAryhsKQQcA4iQNldkbyeviYrPKWjLTjRXT5cD2lpWzr+Jx7mX7InV5JOz1Qq+P+nJW YIBjUKhI03ux89p58CYil24Zpyn2F5cX7U+inY8lJIBwLPBnc9Z0An/DVnUOD+0wIcYVnZAK DiIXODkGqTg3fhZwbbi+KAhtHPFM2fGw2VTUf62IHzV+eBSnamzPOBc1XsJYKRo3FHNeLuS8 f4wUe7bWb9O66PPFK/RkeqNX6akkFBf9VfrZ1rTEKAyJ2uqf1EI1olYnENk4+00IBa+BavGQ 8UW9dGW3nbPrfuOV5UUvbnsSQwj67pSdrBQqilr5N/5H9z7VCDQ0dhuJNtvDSlTf2iUFBqgk 3smln31PUYiVPrMP0V4ja0i9qtO/TB01rTfTyXTRtqz53qO5dGsYiliJO5aUmh8swVpotgK4 /57h3zGsaXO9PGgnnAdqeKVITaFTLY1ISg+Ptb4KoliiOjrBMmQUSJVtkUXMrCMCeuPDGHo7 39Xc75lcHlGuM3yEB//htKjyprbLeLf1y4xPyTeeF5zg/0ztRZNKZicgEmxyUNBHHnBKHQxz 1j+mzH0HjZZtXjGu2KLJ18G07q0fpz2ZPk2D53Ww39VNI/J9ABEBAAHCwV8EGAECAAkFAk6S 54YCGwwACgkQvSWxBAa0cEk3tRAAgO+DFpbyIa4RlnfpcW17AfnpZi9VR5+zr496n2jH/1ld wRO/S+QNSA8qdABqMb9WI4BNaoANgcg0AS429Mq0taaWKkAjkkGAT7mD1Q5PiLr06Y/+Kzdr 90eUVneqM2TUQQbK+Kh7JwmGVrRGNqQrDk+gRNvKnGwFNeTkTKtJ0P8jYd7P1gZb9Fwj9YLx jhn/sVIhNmEBLBoI7PL+9fbILqJPHgAwW35rpnq4f/EYTykbk1sa13Tav6btJ+4QOgbcezWI wZ5w/JVfEJW9JXp3BFAVzRQ5nVrrLDAJZ8Y5ioWcm99JtSIIxXxt9FJaGc1Bgsi5K/+dyTKL wLMJgiBzbVx8G+fCJJ9YtlNOPWhbKPlrQ8+AY52Aagi9WNhe6XfJdh5g6ptiOILm330mkR4g W6nEgZVyIyTq3ekOuruftWL99qpP5zi+eNrMmLRQx9iecDNgFr342R9bTDlb1TLuRb+/tJ98 f/bIWIr0cqQmqQ33FgRhrG1+Xml6UXyJ2jExmlO8JljuOGeXYh6ZkIEyzqzffzBLXZCujlYQ DFXpyMNVJ2ZwPmX2mWEoYuaBU0JN7wM+/zWgOf2zRwhEuD3A2cO2PxoiIfyUEfB9SSmffaK/ S4xXoB6wvGENZ85Hg37C7WDNdaAt6Xh2uQIly5grkgvWppkNy4ZHxE+jeNsU7tg= In-Reply-To: <20250514015554.19978-3-nico@fluxnic.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 14. 05. 25, 3:52, Nicolas Pitre wrote: ... > So let's work around this limitation by adding TIOCL_GETCURSORPOS as a > fallback method to get the cursor position when /dev/vcsa reports 255. ... > --- a/drivers/tty/vt/vt.c > +++ b/drivers/tty/vt/vt.c ... > +/* invoked via ioctl(TIOCLINUX) */ > +static int get_cursor_pos(struct tty_struct *tty) > +{ > + struct vc_data *vc = tty->driver_data; > + unsigned int x, y; > + > + console_lock(); > + x = vc->state.x; > + y = vc->state.y; > + console_unlock(); > + > + /* > + * Clamp x to 16 bits, y to 15 bits. A display larger than 65535x32767 > + * characters won't be a concern for the foreseeable future. > + * Bit 31 is reserved to represent negative error codes elsewhere. > + */ > + return min(x, 0xFFFFu) | (min(y, 0x7FFFu) << 16); Hmm, I would do a proper struct instead. Like winsize. > --- a/include/uapi/linux/tiocl.h > +++ b/include/uapi/linux/tiocl.h > @@ -38,4 +38,8 @@ struct tiocl_selection { > #define TIOCL_GETKMSGREDIRECT 17 /* get the vt the kernel messages are restricted to */ > #define TIOCL_GETBRACKETEDPASTE 18 /* get whether paste may be bracketed */ > > +#define TIOCL_GETCURSORPOS 20 /* Get screen cursor position */ The same question about man-pages :). thanks, -- js suse labs