[v3.9] [v3.10] [Regression] serial: 8250_pci: add support for another kind of NetMos Technology PCI 9835 Multi-I/O Controller

[v3.9] [v3.10] [Regression] serial: 8250_pci: add support for another kind of NetMos Technology PCI 9835 Multi-I/O Controller

[Joseph Salisbury]

Hi Wang,

A bug was opened against the Ubuntu kernel[0].  After a kernel bisect,
it was found that reverting the following commit resolved this bug:

commit 8d2f8cd424ca0b99001f3ff4f5db87c4e525f366
Author: Wang YanQing <udknight@gmail.com>
Date:   Fri Mar 1 11:47:20 2013 +0800

    serial: 8250_pci: add support for another kind of NetMos Technology
PCI 9835 Multi-I/O Controller


The regression was introduced as of v3.9-rc3 and still exists in the
current Mainline tree.  It was also propagated to the stable trees.

The patch causes the device to use the serial module instead of
parport_serial.  Maybe the the quirk in ~drivers/pci/quirks.c
quirk_netmos() needs to be modified?

I see that you are the author of this patch, so I wanted to run this by
you.  I was thinking of requesting a revert, but I wanted to get your
feedback first.


Thanks,

Joe

Re: [v3.9] [v3.10] [Regression] serial: 8250_pci: add support for another kind of NetMos Technology PCI 9835 Multi-I/O Controller

[Greg KH]

On Mon, Jul 01, 2013 at 12:14:45PM -0400, Joseph Salisbury wrote:
> Hi Wang,
> 
> A bug was opened against the Ubuntu kernel[0].  After a kernel bisect,
> it was found that reverting the following commit resolved this bug:
> 
> commit 8d2f8cd424ca0b99001f3ff4f5db87c4e525f366
> Author: Wang YanQing <udknight@gmail.com>
> Date:   Fri Mar 1 11:47:20 2013 +0800
> 
>     serial: 8250_pci: add support for another kind of NetMos Technology
> PCI 9835 Multi-I/O Controller
> 
> 
> The regression was introduced as of v3.9-rc3 and still exists in the
> current Mainline tree.  It was also propagated to the stable trees.
> 
> The patch causes the device to use the serial module instead of
> parport_serial.  Maybe the the quirk in ~drivers/pci/quirks.c
> quirk_netmos() needs to be modified?
> 
> I see that you are the author of this patch, so I wanted to run this by
> you.  I was thinking of requesting a revert, but I wanted to get your
> feedback first.

You missed the conversation we had about this already this weekend :)

The offending patch has already been reverted and will propagate to the
stable trees soon.

thanks,

greg k-h

Re: [v3.9] [v3.10] [Regression] serial: 8250_pci: add support for another kind of NetMos Technology PCI 9835 Multi-I/O Controller

[Joseph Salisbury]

On 07/01/2013 12:27 PM, Greg KH wrote:
> On Mon, Jul 01, 2013 at 12:14:45PM -0400, Joseph Salisbury wrote:
>> Hi Wang,
>>
>> A bug was opened against the Ubuntu kernel[0].  After a kernel bisect,
>> it was found that reverting the following commit resolved this bug:
>>
>> commit 8d2f8cd424ca0b99001f3ff4f5db87c4e525f366
>> Author: Wang YanQing <udknight@gmail.com>
>> Date:   Fri Mar 1 11:47:20 2013 +0800
>>
>>     serial: 8250_pci: add support for another kind of NetMos Technology
>> PCI 9835 Multi-I/O Controller
>>
>>
>> The regression was introduced as of v3.9-rc3 and still exists in the
>> current Mainline tree.  It was also propagated to the stable trees.
>>
>> The patch causes the device to use the serial module instead of
>> parport_serial.  Maybe the the quirk in ~drivers/pci/quirks.c
>> quirk_netmos() needs to be modified?
>>
>> I see that you are the author of this patch, so I wanted to run this by
>> you.  I was thinking of requesting a revert, but I wanted to get your
>> feedback first.
> You missed the conversation we had about this already this weekend :)
>
> The offending patch has already been reverted and will propagate to the
> stable trees soon.
>
> thanks,
>
> greg k-h
Good news.  Thanks for the help, Greg!

Re: [v3.9] [v3.10] [Regression] serial: 8250_pci: add support for another kind of NetMos Technology PCI 9835 Multi-I/O Controller

[Wang YanQing]

On Mon, Jul 01, 2013 at 12:14:45PM -0400, Joseph Salisbury wrote:
> Hi Wang,
> 
> A bug was opened against the Ubuntu kernel[0].  After a kernel bisect,
> it was found that reverting the following commit resolved this bug:
> 
> commit 8d2f8cd424ca0b99001f3ff4f5db87c4e525f366
> Author: Wang YanQing <udknight@gmail.com>
> Date:   Fri Mar 1 11:47:20 2013 +0800
> 
>     serial: 8250_pci: add support for another kind of NetMos Technology
> PCI 9835 Multi-I/O Controller
> 
> 
> The regression was introduced as of v3.9-rc3 and still exists in the
> current Mainline tree.  It was also propagated to the stable trees.
> 
> The patch causes the device to use the serial module instead of
> parport_serial.  Maybe the the quirk in ~drivers/pci/quirks.c
> quirk_netmos() needs to be modified?
> 
> I see that you are the author of this patch, so I wanted to run this by
> you.  I was thinking of requesting a revert, but I wanted to get your
> feedback first.
> 
> 
> Thanks,
> 
> Joe
Hi all,
I am sorry for it and later reply.

But I am sure I have included the parport_serial in the
kernel for my consumers at the time they report their
PCI 9835 Multi-I/O Controller didn't work which cause
this "culprit" patch.

I don't have the card in hand right now, so I can't
dig into it. After stare into parport_serial.c, yes,
it seems like it will handle this pci serial card.

Maybe I forget or miss something, I hope.

Thanks.