Re: [PATCH v2 4/5] ARM: dts: imx6q: add dte pinctrl for uart2

[Huang Shijie <b32955@freescale.com>]

于 2013年07月04日 15:23, Shawn Guo 写道:
> On Wed, Jul 03, 2013 at 05:42:36PM +0800, Huang Shijie wrote:
>> In imx6q-arm2 board, the UART2 works in the dte mode.
>> So add a pinctrl for it.
>>
>> Signed-off-by: Huang Shijie<b32955@freescale.com>
>> ---
>>   arch/arm/boot/dts/imx6q.dtsi |    9 +++++++++
>>   1 files changed, 9 insertions(+), 0 deletions(-)
> Since imx6q and imx6dl are pin-to-pin compatible, from now on I would
> require the same pin group be added for these two SoC together, so that
> we can enforce the same label name.
>
I knew it.

But this pinctrl is only used in imx6q-arm2 board which uses a big 
armdillo board,
so i did not add the same label to imx6dl.

Do we have a imx6dl-arm2 board? if we have , i can add it.


>> diff --git a/arch/arm/boot/dts/imx6q.dtsi b/arch/arm/boot/dts/imx6q.dtsi
>> index 9a69891..8a518c6 100644
>> --- a/arch/arm/boot/dts/imx6q.dtsi
>> +++ b/arch/arm/boot/dts/imx6q.dtsi
>> @@ -266,6 +266,15 @@
>>   							MX6Q_PAD_EIM_D27__UART2_RX_DATA 0x1b0b1
>>   						>;
>>   					};
>> +
>> +					pinctrl_uart2_dte: uart2grp-2 {
>> +						fsl,pins =<
>> +							MX6Q_PAD_EIM_D26__UART2_RX_DATA 0x1b0b1
>> +							MX6Q_PAD_EIM_D27__UART2_TX_DATA 0x1b0b1
>> +							MX6Q_PAD_EIM_D28__UART2_CTS_B	0x1b0b1
>> +							MX6Q_PAD_EIM_D29__UART2_CTS_B	0x1b0b1
> Why do you have two pads mux-ed on one function?
I think the name of the PAD is wrong.

thanks
Huang Shijie

--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html