* [RFC PATCH 3/7] drivers/tty/serial/serial_core: ratelimit uart_wait_until_sent [not found] <20260306015022.1940986-1-jim.cromie@gmail.com> @ 2026-03-06 1:50 ` Jim Cromie 2026-03-06 6:32 ` Jiri Slaby 0 siblings, 1 reply; 3+ messages in thread From: Jim Cromie @ 2026-03-06 1:50 UTC (permalink / raw) To: linux-kernel, dri-devel, amd-gfx, intel-gvt-dev, intel-gfx Cc: Jim Cromie, Greg Kroah-Hartman, Jiri Slaby, Petr Mladek, Ilpo Järvinen, Dr. David Alan Gilbert, Joseph Tilahun, linux-serial Ratelimiting these pr_debug()s can reduce the console flood during bulk dynamic-debug activation, in environments where a serial console is used. Signed-off-by: Jim Cromie <jim.cromie@gmail.com> --- drivers/tty/serial/serial_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c index 487756947a96..6db465619c70 100644 --- a/drivers/tty/serial/serial_core.c +++ b/drivers/tty/serial/serial_core.c @@ -1790,8 +1790,8 @@ static void uart_wait_until_sent(struct tty_struct *tty, int timeout) expire = jiffies + timeout; - pr_debug("uart_wait_until_sent(%u), jiffies=%lu, expire=%lu...\n", - port->line, jiffies, expire); + pr_debug_ratelimited("waiting on (%u) jiffies=%lu, expire=%lu...\n", + port->line, jiffies, expire); /* * Check whether the transmitter is empty every 'char_time'. -- 2.53.0 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RFC PATCH 3/7] drivers/tty/serial/serial_core: ratelimit uart_wait_until_sent 2026-03-06 1:50 ` [RFC PATCH 3/7] drivers/tty/serial/serial_core: ratelimit uart_wait_until_sent Jim Cromie @ 2026-03-06 6:32 ` Jiri Slaby 2026-03-06 14:02 ` jim.cromie 0 siblings, 1 reply; 3+ messages in thread From: Jiri Slaby @ 2026-03-06 6:32 UTC (permalink / raw) To: Jim Cromie, linux-kernel, dri-devel, amd-gfx, intel-gvt-dev, intel-gfx Cc: Greg Kroah-Hartman, Petr Mladek, Ilpo Järvinen, Dr. David Alan Gilbert, Joseph Tilahun, linux-serial On 06. 03. 26, 2:50, Jim Cromie wrote: > Ratelimiting these pr_debug()s can reduce the console flood during > bulk dynamic-debug activation, in environments where a serial console > is used. > > Signed-off-by: Jim Cromie <jim.cromie@gmail.com> > --- > drivers/tty/serial/serial_core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c > index 487756947a96..6db465619c70 100644 > --- a/drivers/tty/serial/serial_core.c > +++ b/drivers/tty/serial/serial_core.c > @@ -1790,8 +1790,8 @@ static void uart_wait_until_sent(struct tty_struct *tty, int timeout) > > expire = jiffies + timeout; > > - pr_debug("uart_wait_until_sent(%u), jiffies=%lu, expire=%lu...\n", > - port->line, jiffies, expire); > + pr_debug_ratelimited("waiting on (%u) jiffies=%lu, expire=%lu...\n", > + port->line, jiffies, expire); The changed message does not make any sense. -- js suse labs ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC PATCH 3/7] drivers/tty/serial/serial_core: ratelimit uart_wait_until_sent 2026-03-06 6:32 ` Jiri Slaby @ 2026-03-06 14:02 ` jim.cromie 0 siblings, 0 replies; 3+ messages in thread From: jim.cromie @ 2026-03-06 14:02 UTC (permalink / raw) To: Jiri Slaby Cc: linux-kernel, dri-devel, amd-gfx, intel-gvt-dev, intel-gfx, Greg Kroah-Hartman, Petr Mladek, Ilpo Järvinen, Dr. David Alan Gilbert, Joseph Tilahun, linux-serial On Thu, Mar 5, 2026 at 11:32 PM Jiri Slaby <jirislaby@kernel.org> wrote: > > On 06. 03. 26, 2:50, Jim Cromie wrote: > > Ratelimiting these pr_debug()s can reduce the console flood during > > bulk dynamic-debug activation, in environments where a serial console > > is used. > > > > Signed-off-by: Jim Cromie <jim.cromie@gmail.com> > > --- > > drivers/tty/serial/serial_core.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c > > index 487756947a96..6db465619c70 100644 > > --- a/drivers/tty/serial/serial_core.c > > +++ b/drivers/tty/serial/serial_core.c > > @@ -1790,8 +1790,8 @@ static void uart_wait_until_sent(struct tty_struct *tty, int timeout) > > > > expire = jiffies + timeout; > > > > - pr_debug("uart_wait_until_sent(%u), jiffies=%lu, expire=%lu...\n", > > - port->line, jiffies, expire); > > + pr_debug_ratelimited("waiting on (%u) jiffies=%lu, expire=%lu...\n", > > + port->line, jiffies, expire); > > The changed message does not make any sense. > Ackn. Given the narrow rate-limiting purpose, I should have ignored the checkpatch warning and kept the message as is. In any case, my test setup didnt actually use serio, and didnt get flooded by it, so I dont know that this single change would be enough to fix it. I withdraw this particular patch. > > -- > js > suse labs ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-03-06 14:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20260306015022.1940986-1-jim.cromie@gmail.com>
2026-03-06 1:50 ` [RFC PATCH 3/7] drivers/tty/serial/serial_core: ratelimit uart_wait_until_sent Jim Cromie
2026-03-06 6:32 ` Jiri Slaby
2026-03-06 14:02 ` jim.cromie
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox