linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Huang Shijie <b32955@freescale.com>
To: Hector Palacios <hector.palacios@digi.com>
Cc: linux-serial@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	u.kleine-koenig@pengutronix.de, gregkh@linuxfoundation.org,
	marex@denx.de, fabio.estevam@freescale.com, shawn.guo@linaro.org,
	jslaby@suse.cz
Subject: Re: [PATCH v3 2/2] serial: mxs-auart: wait for FIFO to flush before shutdown
Date: Wed, 9 Oct 2013 15:55:08 +0800	[thread overview]
Message-ID: <52550BDC.70204@freescale.com> (raw)
In-Reply-To: <1380785524-20490-3-git-send-email-hector.palacios@digi.com>

于 2013年10月03日 15:32, Hector Palacios 写道:
> This lead to many bytes not being transferred (specially at low
> baudrates), as they were still in the DMA buffer when the AUART was
> shutdown.
I meet a similar bug with the imx.c which is used for the I.MX.

I did not implement the uart_ops->flush_buffer() hook, so the DMA may fails.

So could we add a new flush_buffer hook for mxs-auart?

Please see the Documentation/serail/driver.

thanks
Huang Shijie



--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2013-10-09  7:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-03  7:32 [PATCH v3 0/2] serial: mxs-auart: wait for DMA buffer to flush before shutdown Hector Palacios
2013-10-03  7:32 ` [PATCH v3 1/2] serial: mxs-auart: set the FIFO size to DMA buffer size Hector Palacios
2013-10-03  7:32 ` [PATCH v3 2/2] serial: mxs-auart: wait for FIFO to flush before shutdown Hector Palacios
2013-10-03 18:17   ` Uwe Kleine-König
2013-10-16 19:54     ` Greg KH
2013-10-09  7:55   ` Huang Shijie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52550BDC.70204@freescale.com \
    --to=b32955@freescale.com \
    --cc=fabio.estevam@freescale.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hector.palacios@digi.com \
    --cc=jslaby@suse.cz \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=marex@denx.de \
    --cc=shawn.guo@linaro.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).