From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Scott Wood <scottwood@freescale.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Stuart Yoder <stuart.yoder@freescale.com>,
linux-serial@vger.kernel.org
Subject: Re: [PATCH] serial: Enable Freescale 16550 workaround on arm
Date: Sat, 03 Oct 2015 00:22:38 +0200 [thread overview]
Message-ID: <5286230.7Dic6OMiYf@wuerfel> (raw)
In-Reply-To: <20151002001616.GA3885@home.buserror.net>
On Thursday 01 October 2015 19:16:16 Scott Wood wrote:
>
> +#ifdef CONFIG_SERIAL_8250_FSL
> + if (of_device_is_compatible(np, "fsl,ns16550") ||
> + of_device_is_compatible(np, "fsl,16550-FIFO64"))
> + port->handle_irq = fsl8250_handle_irq;
> +#endif
> +
>
Can you change this to use
if (IS_ENABLED(CONFIG_SERIAL_8250_FSL)) && ...
The resulting code will be the same, it just get a little easier
on the eye.
Other than that, I wonder if we should do this completely differently
and have the respective entries in of_platform_serial_table[] with
an appropriate PORT_* constant to handle the freescale case.
Arnd
next prev parent reply other threads:[~2015-10-02 22:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-02 0:16 [PATCH] serial: Enable Freescale 16550 workaround on arm Scott Wood
2015-10-02 22:22 ` Arnd Bergmann [this message]
2015-10-02 23:49 ` Scott Wood
2015-10-06 13:09 ` Arnd Bergmann
2015-10-07 22:31 ` [PATCH v2] " Scott Wood
2015-10-08 7:45 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5286230.7Dic6OMiYf@wuerfel \
--to=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=scottwood@freescale.com \
--cc=stuart.yoder@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox