From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Hurley Subject: Re: serial core: crash / race condition on unbind Date: Tue, 11 Mar 2014 07:49:56 -0400 Message-ID: <531EF864.5020104@hurleysoftware.com> References: <531E7F81.20400@hurleysoftware.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mailout32.mail01.mtsvc.net ([216.70.64.70]:38798 "EHLO n23.mail01.mtsvc.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753536AbaCKLuB (ORCPT ); Tue, 11 Mar 2014 07:50:01 -0400 In-Reply-To: Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: Geert Uytterhoeven Cc: Greg Kroah-Hartman , linux-serial@vger.kernel.org, "linux-kernel@vger.kernel.org" , Linux-sh list , One Thousand Gnomes On 03/11/2014 06:58 AM, Geert Uytterhoeven wrote: > Hi Peter, > > On Tue, Mar 11, 2014 at 4:14 AM, Peter Hurley wrote: >>> >>> [...] >>> >>> /* >>> * Indicate that there isn't a port here anymore. >>> */ >>> uport->type = PORT_UNKNOWN; >>> >>> state->uart_port = NULL; >> >> How did this ever work? >> >> Detaching the ll driver from the tty port in this manner is not ok; >> as you already note, it blows up if consoles are still running. > > No one unbinds serial drivers using serial_core, as all these drivers are > for fixed hardware? Yep, never tested until now :) Do you need this to work? > Hot-pluggable usb-serial doesn't use serial_core. I guess none of the 8250 PCI adapters are hot-pluggable... Regards, Peter Hurley