From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Hurley Subject: Re: [PATCH 1/2] serial: core: Don't drop DTR if system console Date: Wed, 04 Jun 2014 10:36:29 -0400 Message-ID: <538F2EED.9070104@hurleysoftware.com> References: <7EC4C3FDEFF6492F91DEE16AEE0831E6@vanni.it> <1401891371-4946-1-git-send-email-peter@hurleysoftware.com> <20140604142208.GA1008@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mailout32.mail01.mtsvc.net ([216.70.64.70]:33106 "EHLO n23.mail01.mtsvc.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750933AbaFDOgb (ORCPT ); Wed, 4 Jun 2014 10:36:31 -0400 In-Reply-To: <20140604142208.GA1008@kroah.com> Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: Greg Kroah-Hartman Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Valerio Vanni On 06/04/2014 10:22 AM, Greg Kroah-Hartman wrote: > On Wed, Jun 04, 2014 at 10:16:10AM -0400, Peter Hurley wrote: >> If a tty is opened on a serial console, don't drop DTR on >> last tty close, on tty hangup, or when resetting port hardware >> via TIOCSSERIAL and TIOCSERCONFIG ioctls. >> >> Signed-off-by: Peter Hurley >> --- >> drivers/tty/serial/serial_core.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) > > Is this a regression, or something we have never done? Not sure. I just noticed this was wrong while working on the other fix. Regards, Peter Hurley