linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alex Elder <elder@linaro.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: heikki.krogerus@linux.intel.com, david.daney@cavium.com,
	loic.poulain@intel.com, linux-serial@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] serial: 8250_dw: support high baudrates if possible
Date: Thu, 10 Jul 2014 22:11:58 -0500	[thread overview]
Message-ID: <53BF55FE.9090500@linaro.org> (raw)
In-Reply-To: <20140710231342.GA9557@kroah.com>

On 07/10/2014 06:13 PM, Greg KH wrote:
> On Tue, Jul 01, 2014 at 10:15:34AM -0500, Alex Elder wrote:
>> Currently the Synopsys DesignWare 8250 driver assumes its UART clock
>> runs at a fixed rate.  If a "real" clock was set up using the common
>> clock framework, and that clock's rate is adjustable, it may be
>> possible to support a wider range of baud rates by changing the
>> UART clock rate.
>>
>> This is done by setting up a uart_port->set_termios method that
>> requests a clock rate change if a different rate might make it
>> more likely to achieve a specified baud.  A new function
>> dw8250_adjustable_clk() determines whether such clock rate
>> adjustment is an option.
>>
>> Signed-off-by: Alex Elder <elder@linaro.org>
>> ---
>> v2: Limit clock changing to specific compatible devices.
>>
>>  drivers/tty/serial/8250/8250_dw.c | 57 +++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 57 insertions(+)
> 
> This no longer applies due to other changes in this driver.  Can you
> please refresh it against my tty-next branch of the tty.git tree and
> resend?

Interesting.  Heikki seems to have generalized
byt_set_termios() into dw8250_set_termios(), such
that it's almost the same as what I did.

I think I can just reuse it and simplify my patch
considerably.  But I'll do that in the morning...

					-Alex


> thanks,
> 
> greg k-h
> 

      reply	other threads:[~2014-07-11  3:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-01 15:15 [PATCH v2] serial: 8250_dw: support high baudrates if possible Alex Elder
2014-07-10 23:13 ` Greg KH
2014-07-11  3:11   ` Alex Elder [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53BF55FE.9090500@linaro.org \
    --to=elder@linaro.org \
    --cc=david.daney@cavium.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=loic.poulain@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).